Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glacier parameter g_sifrac (conversion) #217

Merged
merged 3 commits into from
Aug 22, 2022
Merged

Glacier parameter g_sifrac (conversion) #217

merged 3 commits into from
Aug 22, 2022

Conversation

verseve
Copy link
Member

@verseve verseve commented Aug 22, 2022

No description provided.

@verseve
g_sifrac parameter is time dependent
eb04b18 
fix conversion of glacier parameter g_sifrac
@verseve
update docs
428d3de
@verseve verseve requested a review from hboisgon August 22, 2022 09:50
@verseve verseve self-assigned this Aug 22, 2022
@verseve verseve added the bug Something isn't working label Aug 22, 2022
hboisgon
hboisgon approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@hboisgon hboisgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! One comment, you updated the units in the docs/params_vertical but maybe also good to update the unit in the structures as well (ie in sbm.jl, hbv.jl, flextopo.jl) ?

@verseve
Copy link
Member Author

verseve commented Aug 22, 2022

One comment, you updated the units in the docs/params_vertical but maybe also good to update the unit in the structures as well (ie in sbm.jl, hbv.jl, flextopo.jl) ?

Yes, good suggestion! I did update this in commit 2c7580e.

@verseve verseve merged commit 155d050 into master Aug 22, 2022
@visr visr deleted the parameter-g_sifrac branch August 22, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hboisgon hboisgon hboisgon approved these changes

Assignees

@verseve verseve

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@verseve @hboisgon