Local inertial 1D-2D: inflow, reservoirs and lakes #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add river inflow to 1D-2D local inertial model
in case of reservoir or lake location, q_av remained zero
reservoirs or lakes now also possible as part of local inertial 1D-2D model.
add path of CSV file with rating curve or storage curve to logging
water depth h for reservoir and lake locations set at zero as fixed boundary instead of bankfull depth, upstream flow direction is not allowed then.
fix control flow reservoir and lake locations as part of shallow water (boundary points: update volume not required).
JoostBuitink
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inflow (external) added to local inertial 1D-2D model.
Fixed couple of issues related to reservoir and lake locations, and added check (limit flow (set to zero)) when water is not available.