Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/d serie 2023 2 msl 2289 #138

Merged

Conversation

zantDelta
Copy link
Collaborator

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.8% 0.8% Duplication

@carloslubbers
Copy link
Contributor

@zantDelta Are all the .sli files needed in the repository? They weren't there before and now this PR adds a large amount of new files

@zantDelta zantDelta changed the base branch from master to feature/d-serie-2023-2 August 24, 2023 11:32
@zantDelta
Copy link
Collaborator Author

zantDelta commented Aug 24, 2023

on comment of Carlos:

Yes we parse all our benchmarks and tutorials input files (sli) and output files (sld) like for DFoundations and DSheetPiling

@VirginieTrompille
Copy link
Collaborator

Review OK.
Code smell (1) has been solved in other pull request (#137)
Failing tests in TC project Acceptance (GEOLib) are expected because run with old executable. As all tests in project Test (DSerie 2023) pass, it is OK.

@VirginieTrompille
Copy link
Collaborator

Pull request accepted even if Code smell and failing tests:

  • Code smell (1) has been solved in other pull request (Feature/d serie 2023 2 msl 2290 #137)
  • Failing tests in TC project Acceptance (GEOLib) are expected because run with old executable. As all tests in project Test (DSerie 2023) pass, it is OK.

@VirginieTrompille VirginieTrompille merged commit 1308fad into feature/d-serie-2023-2 Aug 24, 2023
14 checks passed
@VirginieTrompille VirginieTrompille deleted the feature/d-serie-2023-2-MSL-2289 branch August 24, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants