Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ship volume to lake/sea to phase transports #5

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add ship volume to lake/sea to phase transports #5

wants to merge 1 commit into from

Conversation

jackvreeken
Copy link
Contributor

  • Check if Excel wrapper still works
  • Add (Python) test for these new outputs
  • Update commit message to elaborate a bit more on why this information is needed
  • Update docs
  • Express as volume, or as discharge? Other quantities are in discharge. I'd prefer discharge then, talk to Otto.

Add ship volume to lake/sea to transport output
cf8001a 
When a ship goes through a lock, water is displaced in the opposite
direction. Depending on how a far-field model connected to the ZSF can
model ships, it makes sense to either replace the displaced ship volume
with water, some type of solid/local air pressure field, or flat out
ignore it.

Note that ignoring the ship displacement will lead to translation waves
in many far-field models. Substituting the displaced ship volume with
water is generally a lesser evil.
@jackvreeken jackvreeken marked this pull request as draft May 3, 2023 12:52
@jackvreeken jackvreeken changed the title Draft: Add ship volume to lake/sea to phase transports Add ship volume to lake/sea to phase transports May 3, 2023
@jackvreeken jackvreeken marked this pull request as ready for review May 3, 2023 12:53
@jackvreeken jackvreeken marked this pull request as draft May 3, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jackvreeken