Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear AME power generation #2783

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

nkokic
Copy link

@nkokic nkokic commented Jan 21, 2025

About the PR

Returned old original AME power generation scaling with completely different function.
Erased most of the magic numbers and introduced function parameters like watts per core, efficiency penalty and tail efficiency factor.
Increased the price of anti-matter fuel few times more. It's anti-matter. It doesn't grow on trees.
Punishment for engineering not rushing alternative power source is way more mild. Instead of whole station suffering, only logistic's bank account needs to suffer.
Rushing alternative power source is now rewarding.

Why / Balance

For new players, it is easier to explain how one AME core is 80kW and how much exactly does each station really need. Good introduction into power optimizations.
Logarithmic AMEs kills purpose of high core count AMEs, forcing engineers to rush to advanced alternatives. This rush can really become very bad introduction to engineering as whole for new players. Even experienced players get stressed out.
Whole reason why AME went logarithmic is to implement "a degenerate strategy", a strategy to force players go towards more advanced solutions as this one should only be temporary.
With increased AME fuel price, engineers are no longer forced to rush power, instead, they are encouraged.

Technical details

Made 3 linear and parametric functions that combine into one in AME C# code.
Increased prices and removed chance of getting AME fuel as salvage reward in YAML code.

Media

AME parameters for the follwoing:

  • Watts per core: 80kW
  • Efficiency penalty: 2
  • Tail efficiency factor: 90%
  • Cores: 4

AME power generation:
(blue: DeltaV's current, red: old original, orange: new)
image

AME power efficiency:
image

Ideal AME power generation, 2 fuel = 1 core:
(old original and new are same graph)
image

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

  • remove: Removed AME fuel from salvage rewards
  • tweak: AME is back to linear with advanced efficiency drop
  • tweak: Increased AME fuel price

@nkokic nkokic requested a review from a team as a code owner January 21, 2025 02:07
@github-actions github-actions bot added size/S 16-63 lines S: Needs Review Changes: C# Changes any cs files labels Jan 21, 2025
@nkokic nkokic requested a review from a team as a code owner January 21, 2025 02:07
@github-actions github-actions bot added the Changes: YML Changes any yml files label Jan 21, 2025
@nkokic
Copy link
Author

nkokic commented Jan 21, 2025

Whole set of functions which can be interacted with can be seen here:
https://www.desmos.com/calculator/rpevgro5ha

@nkokic
Copy link
Author

nkokic commented Jan 21, 2025

With this PR I would also like to make fuel injections a more continuous variable and make antimatter fuel jars deal with floats instead of integers. Expands more capabilities with AME in terms of saving fuel, making it still easy to use, but also free to master.
With approval and assistance from a team.

@Sifb26
Copy link
Contributor

Sifb26 commented Jan 21, 2025

Direction review, 3 days max.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files S: Needs Review size/S 16-63 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants