[@testing-library/cypress] Fix feedback from #37692

[simjes]

Fixing feedback from #37692

The linting will fail due to cypress-io/cypress#5065, any suggestions on how we can resolve this, or does it have to be resolved in the cypress package?

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test.)
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm run lint package-name (or tsc if no tslint.json is present). This fails due to typings in the dependency to cypress, see Cypress + TypeScript 3.6.2 errors due to outdated JQuery types cypress-io/cypress#5065

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: [@testing-library/cypress] New type definition #37692
• If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

[typescript-bot]

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

	master	#38072	diff
Batch compilation
Memory usage (MiB)	97.0	134.1	+38.2%
Type count	16933	32884	+94.2%
Assignability cache size	38546	36986	-4.0%
Subtype cache size	0	0
Identity cache size	16	16	0.0%
Language service
Samples taken	76	89	+17.1%
Identifiers in tests	76	89	+17.1%
getCompletionsAtPosition
Mean duration (ms)	642.4	439.5	-31.6% 🌟
Median duration (ms)	635.8	438.0	-31.1% 🌟
Mean CV	15.0%	14.6%	-2.3%
Worst duration (ms)	829.0	520.7	-37.2% 🌟
Worst identifier	Cypress	getAllByPlaceholderText
getQuickInfoAtPosition
Mean duration (ms)	654.2	421.5	-35.6% 🌟
Median duration (ms)	645.9	420.2	-34.9% 🌟
Mean CV	14.4%	13.7%	-4.8%
Worst duration (ms)	839.9	517.8	-38.4% 🌟
Worst identifier	Cypress	cy

Wow, it looks like all the big movers moved in the right direction! Way to go! 🌟

---

If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

[typescript-bot]

@simjes Thank you for submitting this PR!

🔔 @aaronmcadam @ppi-buck @NoriSte @wKovacs64 @existentialism @airato - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

[typescript-bot]

@simjes The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[aaronmcadam]

This is awesome! So much better ❤️

[wKovacs64]

This looks great, @simjes. Thank you!

The linting will fail due to cypress-io/cypress#5065, any suggestions on how we can resolve this, or does it have to be resolved in the cypress package?

Is it possible to get this merged without lint passing, given it's an upstream issue with Cypress and TS 3.6, @sheetalkamat?

[typescript-bot]

@simjes I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues.

[typescript-bot]

@simjes To keep things tidy, we have to close PRs that aren't mergeable but don't have activity from their author. No worries, though - please open a new PR if you'd like to continue with this change. Thank you!

[simjes]

I guess I'll keep an eye on cypress-io/cypress#5065 and reopen after it is solved @sheetalkamat

[wKovacs64]

I spoke with Gleb on Gitter and it sounds like the plan is to wait until they finish migrating to jQuery v3. It wasn't clear how far off that will be, but it's being worked on in cypress-io/cypress#1229.

[wKovacs64]

jQuery v3 was just merged, just waiting on a release now.

[simjes]

@wKovacs64 sounds good, got updated PR ready. Will check tomorrow.

[simjes]

New PR in #39394