fix(redux-actions): createAction<Payload>(actionType: string) is incorrect.

[meowtec]

createAction(actionType: string) and createAction(actionType: string) is incorrect

also see #15697

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: <>
• Increase the version number in the header if appropriate.
• If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

[dt-bot]

types/redux-actions/index.d.ts

to authors (@jaysoo @alexgorbatchev). Could you review this PR?
👍 or 👎?

Checklist

• pass the Travis CI test?

[ghost]

This can't be right -- now there are 2 single-argument and they return different results.

[meowtec]

I find a similar example:

  public static create<T0>(): Dispatcher1<T0>;
  public static create<T0, T1>(): Dispatcher2<T0, T1>;
  public static create<T0, T1, T2>(): Dispatcher3<T0, T1, T2>;

from microsoft/TypeScript#1024 (comment) .

And I also test my new definition:

const act0 = ReduxActions.createAction('ACTION0')
const act1 = ReduxActions.createAction<string>('ACTION1')

act0().payload // void
act1('hello').payload // string

It seem to be expected.

[ghost]

Thanks!

[meowtec]

Maybe I have made a mistake (break change).

Because now the code below will get an error:

createAction('ACTION')('payload') // error
// createAction<string>('ACTION')('payload') // ok

I think it will be better if we define like this:

export function createAction(
    actionType: string
): ActionFunctionAny<Action<any>>; // any instead of 0

or

export function createAction(
    actionType: string
): <T>(arg?: T) => Action<T>;

[ghost]

Sound good, you can make a PR.