Move types that were in xmpp-jid to xmpp__jid, since they are for @xmpp/jid, not xmpp-jid.
#15279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
|
xmpp__jid/index.d.ts Checklist
|
ghost
mentioned this pull request
mhegazy
approved these changes
Mar 23, 2017
|
@andy-ms can you file an issue to track supporting this on the compiler side for module resolution. we also need to document it at some point. |
|
Ran |
added 2 commits
March 24, 2017 08:38
… `@xmpp/jid`, not `xmpp-jid`.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15263 was a mistake.
xmpp-jidprovides its own types, but those types were actually for@xmpp/jid.This is a tentative PR based on the assumption that
xmpp__jidis the naming scheme we will use. Needs approval first. @mhegazy @vladima @RyanCavanaughI don't think
@types/xmpp-jidwould have worked in the first place anyway, since it was written in an external module style and would only have matched imports toxmpp-jidanyway. @PJakcson (ref: #14702)