Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump html2text from 2020.1.16 to 2024.2.26 #9990

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Bump html2text from 2020.1.16 to 2024.2.26 #9990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98c9ce6
Bump html2text from 2020.1.16 to 2024.2.26
dependabot[bot] Apr 22, 2024
1acad15
Fixing Spotbugs unit test error with new html2text version (#10003)
cneill Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ django-watson==1.6.3
django-prometheus==2.3.1
Django==4.1.13
djangorestframework==3.14.0
html2text==2020.1.16
html2text==2024.2.26
humanize==4.9.0
jira==3.8.0
PyGithub==1.58.2
Expand Down
13 changes: 4 additions & 9 deletions unittests/tools/test_spotbugs_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@


class TestSpotbugsParser(DojoTestCase):

def test_no_findings(self):
parser = SpotbugsParser()
findings = parser.get_findings(get_unit_tests_path() + "/scans/spotbugs/no_finding.xml", Test())
Expand Down Expand Up @@ -76,19 +75,15 @@ def test_description(self):
test_finding = findings[0]
# Test if line 13 is correct
self.assertEqual(
"At IdentityFunctionCommandInjection.kt:[lines 20-170]",
test_finding.description.splitlines()[12]
"At IdentityFunctionCommandInjection.kt:[lines 20-170]", test_finding.description.splitlines()[12]
)

def test_mitigation(self):
parser = SpotbugsParser()
findings = parser.get_findings(get_unit_tests_path() + "/scans/spotbugs/many_findings.xml", Test())
test_finding = findings[0]
# Test if line 10 is correct
self.assertEqual(
"#### Example",
test_finding.mitigation.splitlines()[9]
)
# Test if line 8 is correct
self.assertEqual("#### Example", test_finding.mitigation.splitlines()[7])

def test_references(self):
parser = SpotbugsParser()
Expand All @@ -97,7 +92,7 @@ def test_references(self):
# Test if line 2 is correct
self.assertEqual(
"[OWASP: Top 10 2013-A1-Injection](https://www.owasp.org/index.php/Top_10_2013-A1-Injection)",
test_finding.references.splitlines()[1]
test_finding.references.splitlines()[1],
)

def test_version_4_4(self):
Expand Down
Loading