Fix: Broken Swagger when Remote User enabled

[kiblik]

Combination of #9108 and enabled DD_AUTH_REMOTEUSER_ENABLED was breaking API Swagger because of removed settings.SWAGGER_SETTINGS.

uwsgi-1         | [18/Apr/2024 12:50:56] ERROR [dojo.api_v2.exception_handler:41] 'Settings' object has no attribute 'SWAGGER_SETTINGS'
uwsgi-1         | Traceback (most recent call last):
uwsgi-1         |   File "/usr/local/lib/python3.11/site-packages/rest_framework/views.py", line 506, in dispatch
uwsgi-1         |     response = handler(request, *args, **kwargs)
uwsgi-1         |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
uwsgi-1         |   File "/usr/local/lib/python3.11/site-packages/drf_spectacular/views.py", line 84, in get
uwsgi-1         |     return self._get_schema_response(request)
uwsgi-1         |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
uwsgi-1         |   File "/usr/local/lib/python3.11/site-packages/drf_spectacular/views.py", line 92, in _get_schema_response
uwsgi-1         |     data=generator.get_schema(request=request, public=self.serve_public),
uwsgi-1         |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
uwsgi-1         |   File "/usr/local/lib/python3.11/site-packages/drf_spectacular/generators.py", line 281, in get_schema
uwsgi-1         |     paths=self.parse(request, public),
uwsgi-1         |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
uwsgi-1         |   File "/usr/local/lib/python3.11/site-packages/drf_spectacular/generators.py", line 252, in parse
uwsgi-1         |     operation = view.schema.get_operation(
uwsgi-1         |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^
uwsgi-1         |   File "/usr/local/lib/python3.11/site-packages/drf_spectacular/openapi.py", line 103, in get_operation
uwsgi-1         |     auth = self.get_auth()
uwsgi-1         |            ^^^^^^^^^^^^^^^
uwsgi-1         |   File "/usr/local/lib/python3.11/site-packages/drf_spectacular/openapi.py", line 342, in get_auth
uwsgi-1         |     names, definitions = [scheme.name], [scheme.get_security_definition(self)]
uwsgi-1         |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
uwsgi-1         |   File "/app/dojo/remote_user.py", line 108, in get_security_definition
uwsgi-1         |     return settings.SWAGGER_SETTINGS['SECURITY_DEFINITIONS']['remoteUserAuth']
uwsgi-1         |            ^^^^^^^^^^^^^^^^^^^^^^^^^
uwsgi-1         |   File "/usr/local/lib/python3.11/site-packages/django/conf/__init__.py", line 94, in __getattr__
uwsgi-1         |     val = getattr(_wrapped, name)
uwsgi-1         |           ^^^^^^^^^^^^^^^^^^^^^^^
uwsgi-1         | AttributeError: 'Settings' object has no attribute 'SWAGGER_SETTINGS'
uwsgi-1         | [18/Apr/2024 12:50:56] ERROR [django.request:241] Internal Server Error: /api/v2/oa3/schema/

Unittest added as well.
Now it should work fine.

[dryrunsecurity]

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security	Status	Findings
AppSec Analyzer (beta)	✅	0 findings
Secrets Analyzer	✅	0 findings
Authn/Authz Analyzer	❕	1 findings
Configured Codepaths Analyzer	✅	0 findings
Sensitive Files Analyzer	✅	0 findings

Note

🟢 Risk threshold not exceeded.

Tip

Get answers to your security questions. Add a comment in this PR starting with @DryRunSecurity. For example...

@dryrunsecurity What are common security issues with web application cookies?

Powered by DryRun Security

[mtesauro]

Approved