-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test description for AWS SecurityHub Scan #9904
add test description for AWS SecurityHub Scan #9904
Conversation
Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.
Note 🟢 Risk threshold not exceeded. Powered by DryRun Security |
The rest of the Ruff Linter will be fixed here: https://github.com/DefectDojo/django-DefectDojo/pull/9903/files |
119803f
to
db9e632
Compare
@manuel-sommer You might want to look at @cneill 's points in #9912 - not the same thing as you're doing here but also about adding items to the description of AWS Sec Hub |
I looked at the PR @mtesauro and reviewed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change on the Test name but otherwise looks good!
Co-authored-by: Charles Neill <[email protected]>
Done @cneill |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
* add test description for AWS SecurityHub Scan * ruff, W293 * Update dojo/tools/awssecurityhub/parser.py Co-authored-by: Charles Neill <[email protected]> * ruff --------- Co-authored-by: Charles Neill <[email protected]>
No description provided.