Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test description for AWS SecurityHub Scan #9904

Merged
merged 5 commits into from
May 2, 2024

Conversation

manuel-sommer
Copy link
Contributor

No description provided.

Copy link

dryrunsecurity bot commented Apr 9, 2024

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Configured Codepaths Analyzer 0 findings
Sensitive Files Analyzer 0 findings
AppSec Analyzer 0 findings
Authn/Authz Analyzer 0 findings
Secrets Analyzer 0 findings

Note

🟢 Risk threshold not exceeded.

Powered by DryRun Security

@github-actions github-actions bot added the parser label Apr 9, 2024
@manuel-sommer
Copy link
Contributor Author

The rest of the Ruff Linter will be fixed here: https://github.com/DefectDojo/django-DefectDojo/pull/9903/files

@manuel-sommer manuel-sommer force-pushed the add_testdesc_for_awssechub branch from 119803f to db9e632 Compare April 12, 2024 03:28
@mtesauro
Copy link
Contributor

@manuel-sommer You might want to look at @cneill 's points in #9912 - not the same thing as you're doing here but also about adding items to the description of AWS Sec Hub

@manuel-sommer
Copy link
Contributor Author

I looked at the PR @mtesauro and reviewed it.

Copy link
Contributor

@cneill cneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change on the Test name but otherwise looks good!

dojo/tools/awssecurityhub/parser.py Outdated Show resolved Hide resolved
@manuel-sommer manuel-sommer requested a review from cneill April 23, 2024 00:29
@manuel-sommer
Copy link
Contributor Author

Done @cneill

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Maffooch Maffooch merged commit aa8ee18 into DefectDojo:dev May 2, 2024
123 checks passed
dogboat pushed a commit to dogboat/django-DefectDojo that referenced this pull request May 6, 2024
* add test description for AWS SecurityHub Scan

* ruff, W293

* Update dojo/tools/awssecurityhub/parser.py

Co-authored-by: Charles Neill <[email protected]>

* ruff

---------

Co-authored-by: Charles Neill <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants