#6620 Create API importer for Bugcrowd

[Gby56]

Implements #6620

Needs testing too

[Gby56]

I have added a regex parsing for endpoints because I kept getting errors I have mentioned in #6580 ! Submissions can have random stuff in their bug_url, not just urls which is annoying...

[Maffooch]

@Gby56 This is a great start here! There a couple things left to do before we can approve

• Fix flake 8 errors
• Add some unit tests. This would be good starting place

[damiencarol]

There is a few changes needed, also unit tests are missing.

[Gby56]

@Maffooch all good :) I copied tests from Edgescan

[damiencarol]

@Gby56

1. when I said use urlencode method instead, I was refering to something like this:

import urllib.request
import urllib.parse
params = urllib.parse.urlencode({'spam': 1, 'eggs': 2, 'bacon': 0})
url = "http://www.musi-cal.com/cgi-bin/query?%s" % params
with urllib.request.urlopen(url) as f:
    print(f.read().decode('utf-8'))

Which is easier to read and less bug prone (instead of pushing the string encoded directly in the code).

2. We should convert this method get_findings(self, program, target) to be a generator function.
   If I understand well the data returned by GitLab API, the data are paginated.
   Which means that the function could return multiple time data. Perfect use case for a generator function.

[kiblik]

Hi @Gby56,

I'm not sure that merging master to this branch was the best step. I suppose you wanted to merge dev.

I'm adding also a couple of comments to your changes.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[Gby56]

@kiblik yeah I did the upstream fetch on my fork and it pulled the master, but now that I merged dev into my branch it's not working either, anyways I copied over the exact files from dev and there are no conflicts here, it's weird how the diff is showing

[Gby56]

I think it’s fine though ? It’s the same as the dev branch anyways

…

On Tue 13 Sep 2022 at 21:55, kiblik ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In components/package.json <#6621 (comment)> : > @@ -1,6 +1,6 @@ { "name": "defectdojo", - "version": "2.14.0-dev", + "version": "2.15.0-dev", Unfortunately, I'm not able to help you here. I have no idea. But I would try git rebase dev — Reply to this email directly, view it on GitHub <#6621 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABTFKKCFPAAQSSBSEMMXMITV6DL4VANCNFSM545DRKNA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[Gby56]

the init file probably didn't get linted with black, the string delimiters were just different

[Gby56]

@kiblik tell me if everything is ok for you, I have added the feedback from the http responses in case of a failure as requested

[kiblik]

Yes @Gby56, it looks good to me. Thank you for the changes and your effort.
Unfortunately, I do not have "approval" or "merge" rights here, so you will need to wait or ask somebody else.