Ruff: Add and fix PTH113

[manuel-sommer]

Add ruff PTH113

[dryrunsecurity]

DryRun Security Summary

This pull request includes several changes across multiple files in the DefectDojo application, primarily focused on improving security, performance, and configurability, such as enabling HTTPS redirection, configuring the Celery message broker, and adding new configuration options for encryption keys, team name, and logging handler.

Expand for full summary

Summary:

This pull request includes several changes across multiple files in the DefectDojo application, primarily focused on improving security, performance, and configurability. The key changes include:

1. Security Improvements: The settings.dist.py file has been updated to enable various security-related settings, such as HTTPS redirection, content type sniffing prevention, secure cookies, and HTTP Strict Transport Security (HSTS).

2. Performance Improvements: The settings.dist.py file also includes changes to configure the Celery message broker, define scheduled tasks, and limit the maximum number of search results, similar findings, and API request/response pairs.

3. Configuration Updates: The settings.dist.py file has been updated to add new configuration options, such as encryption keys, team name, footer version, tagging behavior, JIRA issue type choices, and logging handler.

4. API and Deduplication Configuration: The settings.dist.py file now includes settings to configure API token authentication and the deduplication algorithm and fields used for each scanner.

Overall, these changes aim to improve the security, performance, and flexibility of the DefectDojo application, which is a critical tool for managing and tracking security vulnerabilities. As an application security engineer, I would recommend thoroughly reviewing these changes to ensure they are implemented correctly and do not introduce any unintended security or performance issues.

Files Changed:

1. dojo/settings/.settings.dist.py.sha256sum: The SHA-256 hash value for the .settings.dist.py file has been updated, indicating that the file's contents have been modified.
2. ruff.toml: The Ruff linter configuration has been updated, including the addition of the PTH113 rule and the removal of the D211 rule.
3. unittests/test_parsers.py: The unit tests for the DefectDojo parsers have been updated to improve file existence checks, documentation checks, and test data checks.
4. dojo/settings/settings.dist.py: This file, which contains the default settings for the DefectDojo application, has been significantly updated to improve security, performance, and configurability.

Code Analysis

We ran 9 analyzers against 4 files and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

[mtesauro]

Approved

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.