Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burp Enterprise: Add hash code fields #11179

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

Maffooch
Copy link
Contributor

@Maffooch Maffooch commented Nov 1, 2024

Burp Enterprise does not have any dedupe fields

[sc-8057]

@Maffooch Maffooch added the bugfix label Nov 1, 2024
@github-actions github-actions bot added the settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR label Nov 1, 2024
Copy link

dryrunsecurity bot commented Nov 1, 2024

DryRun Security Summary

The changes in this pull request focus on updating the configuration and integration of the Burp Enterprise Scan parser within the DefectDojo application, including improvements to the deduplication and parsing of findings from the Burp Enterprise Scan tool.

Expand for full summary

Summary:

The changes in this pull request are focused on updating the configuration and integration of the Burp Enterprise Scan parser within the DefectDojo application. The changes include updating the saml2_attrib_map_format function to include new mappings for the "Burp Enterprise Scan" parser, and modifying the DEDUPLICATION_ALGORITHM_PER_PARSER dictionary to use a hash-based deduplication algorithm for the Burp Enterprise Scan parser.

These changes are aimed at improving the accuracy and efficiency of the Burp Enterprise Scan integration within DefectDojo, which is an important aspect of effective vulnerability management. The use of a hash-based deduplication algorithm suggests that the developers have identified issues with the unique ID provided by the Burp Enterprise Scan tool, and this change should help to prevent the same vulnerability from being reported multiple times, leading to more efficient remediation efforts.

From an application security perspective, these changes do not introduce any obvious security vulnerabilities, as they are focused on improving the functionality and integration of a third-party security tool within the DefectDojo application. However, it's always important to review any changes, even those that are not directly related to security-sensitive functionality, to ensure that they do not have any unintended consequences or side effects that could impact the application's security posture.

Files Changed:

  1. dojo/settings/.settings.dist.py.sha256sum: This file contains the checksum for the settings.dist.py file, which is used to verify the integrity of the configuration file. The changes in this file update the checksum value, indicating that the contents of the settings.dist.py file have been modified. While this change is not inherently concerning, it's important to review the actual changes made to the settings.dist.py file to ensure that no security-sensitive configurations or settings have been modified in a way that could introduce vulnerabilities or security risks.

  2. dojo/settings/settings.dist.py: The changes in this file are focused on improving the deduplication and parsing of findings from the Burp Enterprise Scan tool within the DefectDojo application. The changes include updating the saml2_attrib_map_format function to include new mappings for the "Burp Enterprise Scan" parser, and modifying the DEDUPLICATION_ALGORITHM_PER_PARSER dictionary to use a hash-based deduplication algorithm for the Burp Enterprise Scan parser. These changes are aimed at improving the accuracy and efficiency of the Burp Enterprise Scan integration within DefectDojo.

Code Analysis

We ran 9 analyzers against 2 files and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch merged commit 2171d67 into DefectDojo:dev Nov 4, 2024
73 checks passed
@Maffooch Maffooch deleted the burp-enterprise branch November 4, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants