Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logo for docs, add knowledge base link #11158

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

paulOsinski
Copy link
Contributor

@paulOsinski paulOsinski commented Oct 29, 2024

Changing the logo for the docs (documentation.defectdojo.com) page, and add link to knowledge base

Screenshot 2024-10-29 at 12 12 26 PM

Copy link

dryrunsecurity bot commented Oct 29, 2024

DryRun Security Summary

The pull request updates the navigation menu and optimizes the logo asset for the DefectDojo documentation website, including adding a new "Knowledge Base" menu item and reducing the size and simplifying the logo SVG file.

Expand for full summary

Summary:

The changes in this pull request are focused on updating the navigation menu and optimizing the logo asset for the DefectDojo documentation website. The key changes include adding a new "Knowledge Base" menu item that links to the support.defectdojo.com URL, and optimizing the logo SVG file by reducing its size and simplifying the shapes and paths used to render the image.

From an application security perspective, these changes do not introduce any obvious security concerns. The updates to the navigation menu and the logo asset are common and expected modifications for a documentation website, and they do not appear to involve any new functionality or external dependencies that could potentially introduce security vulnerabilities.

However, it is always important to review any changes, even if they seem minor, to ensure that they do not have any unintended consequences or introduce any security issues. In this case, the changes seem reasonable and focused on improving the user experience and performance of the documentation website.

Files Changed:

  1. docs/config.dev.toml: This file contains the configuration for the navigation menu of the DefectDojo documentation website. The changes add a new menu item for the "Knowledge Base" section, which links to the support.defectdojo.com URL.
  2. docs/config.master.toml: Similar to the changes in the config.dev.toml file, this change adds a new menu item for the "Knowledge Base" section to the main navigation menu of the documentation website.
  3. docs/assets/icons/logo.svg: This change updates the logo SVG file, reducing its size and simplifying the shapes and paths used to render the image. The new logo uses a color palette of #147cc4, #f4541c, and #4c68c8.

Code Analysis

We ran 9 analyzers against 3 files and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@github-actions github-actions bot added the docs label Oct 29, 2024
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro mtesauro merged commit abb7735 into DefectDojo:bugfix Oct 29, 2024
73 checks passed
@paulOsinski paulOsinski deleted the logochange branch November 27, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants