Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broker configuration fix for deployment #11109

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

JGodin-C2C
Copy link
Contributor

Description

The deployment using helm is not working at the moment when using the default values.
As redis.master is not existant in the values.yaml, it crashes when it tries to render template.

Test results

One can now deploy defectdojo.

  • Make sure to rebase your PR against the very latest dev.
  • Features/Changes should be submitted against the dev.
  • Bugfixes should be submitted against the bugfix branch.
  • Give a meaningful name to your PR, as it may end up being used in the release notes.

@github-actions github-actions bot added the helm label Oct 21, 2024
Copy link

dryrunsecurity bot commented Oct 21, 2024

DryRun Security Summary

The pull request updates the Celery broker settings for the DefectDojo application to ensure that the Celery broker port is correctly set based on the Redis configuration, which can be useful if the Redis configuration is different from the default.

Expand for full summary

Summary:

The code change in this pull request is related to the configuration of the Celery broker settings for the DefectDojo application. The key change is the update to the logic for setting the Celery broker port, which now checks the Redis configuration and uses the appropriate port value. This change ensures that the Celery broker port is correctly set based on the Redis configuration, which can be useful if the Redis configuration is different from the default.

From an application security perspective, this change does not introduce any obvious security concerns. However, it's important to review the overall application architecture and security controls to ensure that the Celery broker and other components are properly secured, such as ensuring that the Celery broker is not directly accessible from the internet, implementing proper authentication and authorization mechanisms, and ensuring that the Celery broker communication is encrypted if necessary.

Files Changed:

  • helm/defectdojo/templates/configmap.yaml: This file contains the configuration for the DefectDojo application, including the Celery broker settings. The patch updates the logic for setting the Celery broker port, which now checks the Redis configuration and uses the appropriate port value. This change ensures that the Celery broker port is correctly set based on the Redis configuration, which can be useful if the Redis configuration is different from the default.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

helm/defectdojo/templates/configmap.yaml Outdated Show resolved Hide resolved
@JGodin-C2C JGodin-C2C force-pushed the fix_celery_broker_config branch from d80774d to 62716e2 Compare October 28, 2024 09:39
@JGodin-C2C JGodin-C2C requested a review from cneill October 28, 2024 09:39
@JGodin-C2C JGodin-C2C force-pushed the fix_celery_broker_config branch from 62716e2 to b86825b Compare October 28, 2024 09:50
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro mtesauro merged commit e49d933 into DefectDojo:bugfix Oct 28, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants