-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: broker configuration fix for deployment #11109
fix: broker configuration fix for deployment #11109
Conversation
DryRun Security SummaryThe pull request updates the Celery broker settings for the DefectDojo application to ensure that the Celery broker port is correctly set based on the Redis configuration, which can be useful if the Redis configuration is different from the default. Expand for full summarySummary: The code change in this pull request is related to the configuration of the Celery broker settings for the DefectDojo application. The key change is the update to the logic for setting the Celery broker port, which now checks the Redis configuration and uses the appropriate port value. This change ensures that the Celery broker port is correctly set based on the Redis configuration, which can be useful if the Redis configuration is different from the default. From an application security perspective, this change does not introduce any obvious security concerns. However, it's important to review the overall application architecture and security controls to ensure that the Celery broker and other components are properly secured, such as ensuring that the Celery broker is not directly accessible from the internet, implementing proper authentication and authorization mechanisms, and ensuring that the Celery broker communication is encrypted if necessary. Files Changed:
Code AnalysisWe ran Riskiness🟢 Risk threshold not exceeded. |
d80774d
to
62716e2
Compare
Signed-off-by: Julien Godin <[email protected]>
62716e2
to
b86825b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Description
The deployment using helm is not working at the moment when using the default values.
As redis.master is not existant in the values.yaml, it crashes when it tries to render template.
Test results
One can now deploy defectdojo.
dev
.dev
.bugfix
branch.