Groups/users labels text

[dogboat]

Description

This patch updates some of the labels/wording on the Groups and Users view pages.

Test results

Viewing the pages yields updated text.

Screenshots

Group (with no associations):

(If a Group was empty, it'd say "This Group has no members." in line with the other sections.)

Group (with associations):

User (without associations):

User (with associations):

[sc-3273]

[dryrunsecurity]

DryRun Security Summary

The pull request focuses on improving the user interface and readability of the "Group" and "User" pages in the DefectDojo application, without introducing any obvious security concerns, by updating headings, terminology, and messages to provide more context and clarity to the users.

Expand for full summary

Summary:

The code changes in this pull request are focused on improving the user interface and readability of the "Group" and "User" pages in the DefectDojo application. The changes aim to provide more context and clarity to the users by updating headings, terminology, and messages displayed on the pages. These changes do not introduce any obvious security concerns, as they are primarily focused on enhancing the user experience and usability of the application.

Files Changed:

1. dojo/templates/dojo/view_group.html:

   • The heading for the group page has been updated to include the word "Group:" for clarity.
   • The headings and messages for the "Members", "Product Type Groups", and "Product Groups" sections have been improved to provide more context.
   • The messages displayed when there are no members or groups have been updated to be more informative.

2. dojo/templates/dojo/view_user.html:

   • The heading for the user page has been updated to include the word "User:" for clarity.
   • The section titles have been updated to use more descriptive and clear language, such as "Product Types this User can access" and "Products this User can access".
   • The messages displayed when there are no product types, products, or groups associated with the user have been updated to be more informative.
   • The code includes various permission checks and dropdown menus that allow authorized users to perform actions such as adding product types, products, or groups to the user, as well as editing or deleting the user's memberships, suggesting a robust permissions system in the application.

Overall, these changes appear to be focused on improving the user experience and clarity of the information displayed, rather than introducing any significant security-related changes. However, it's important to ensure that the existing security and permissions controls are maintained and properly implemented throughout the application.

Code Analysis

We ran 9 analyzers against 2 files and 1 analyzer had findings. 8 analyzers had no findings.

Analyzer	Findings
Authn/Authz Analyzer	3 findings

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[mtesauro]

Approved