Veracode: Add additional severity mappings for other informational fi…

…ndings (#8653) * Add additional severity mappings for other informational findings * Update unit tests
DefectDojo · Sep 13, 2023 · 59870cc · 59870cc · alles-klar · Sep 15, 2023
1 parent 16c4462
commit 59870cc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/Dockerfile.integration-tests-debian b/Dockerfile.integration-tests-debian
@@ -39,7 +39,7 @@ RUN \
   chrome_version=$(apt-cache show google-chrome-stable | grep Version | awk '{print $2}' | cut -d '-' -f 1) && \
   chrome_version_blob=$(curl -k https://googlechromelabs.github.io/chrome-for-testing/known-good-versions-with-downloads.json | jq ".versions[] | select(.version==\"$chrome_version\")") && \
   chromedriver_url=$(echo $chrome_version_blob | jq -r ".downloads.chromedriver[] | select(.platform==\"linux64\") | .url") && \
-  wget https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/115.0.5790.98/linux64/chromedriver-linux64.zip && \
+  wget $chromedriver_url && \
   unzip -j chromedriver-linux64.zip chromedriver-linux64/chromedriver && \
   rm -rf chromedriver-linux64.zip && \
   chmod -R 0755 .

diff --git a/dojo/tools/veracode/json_parser.py b/dojo/tools/veracode/json_parser.py
@@ -25,6 +25,7 @@ class VeracodeJSONParser(object):
     """
 
     severity_mapping = {
+        0: "Info",
         1: "Info",
         2: "Low",
         3: "Medium",
@@ -89,7 +90,7 @@ def get_items(self, tree, test):
 
     def create_finding_from_details(self, finding_details, scan_type, policy_violated) -> Finding:
         # Fetch the common attributes that should be in every scan type
-        severity = self.severity_mapping.get(finding_details.get("severity", 1))
+        severity = self.severity_mapping.get(finding_details.get("severity", 1), 1)
         # Set up the finding with just severity for now
         finding = Finding(
             title=f"{scan_type} Finding",