CLI gating of commands and options by tier #882
Conversation
nullfunc
force-pushed
the
eric-tier-feature-gating
branch
from
f2bd0e0
to
47ba047
Compare
| GetParametersByPath(ctx context.Context, params *ssm.GetParametersByPathInput, optFns ...func(*ssm.Options)) (*ssm.GetParametersByPathOutput, error) | ||
| } | ||
|
|
||
| var longRetryCfg = PanicOnError(config.LoadDefaultConfig(context.Background(), |
There was a problem hiding this comment.
I suspect this might remove all the nice error messages we've added when region etc. are not set and cause a panic instead.
src/cmd/cli/command/commands.go
Outdated
| @@ -49,6 +50,7 @@ var ( | |||
| nonInteractive = !hasTty | |||
| providerID = cliClient.ProviderID(pkg.Getenv("DEFANG_PROVIDER", "auto")) | |||
| verbose = false | |||
| whoami *defangv1.WhoAmIResponse | |||
There was a problem hiding this comment.
Feels like this could be something that's inside the GrpcClient
|
|
||
| if StsClient == nil { | ||
| cfg := aws.PanicOnError(b.driver.LoadConfig(ctx)) | ||
| StsClient = sts.NewFromConfig(cfg) |
There was a problem hiding this comment.
Not liking the panic. What would it look like if we'd add the stsClient pointer to the ByocAws structure? And change the old code to "create if not initialized"?
| { | ||
| name: "no permission for gpu", | ||
| action: ActionRequest{ | ||
| role: defangv1.SubscriptionTier_PERSONAL, |
| role: defangv1.SubscriptionTier_PRO, | ||
| action: "compose-up", | ||
| resource: "gpu", | ||
| detail: "1", |
There was a problem hiding this comment.
We already have a quota structure, so kinda expected us to leverage, extend, or replace that one.
There was a problem hiding this comment.
True, this is redundant and easily lead to inconsistency. Will make this reference the quota struct then.
There was a problem hiding this comment.
not sure "permission" is the right term, since it feels like it's an auth issue.
…ible everywhere permissions need to be checked.
Description
Add permission checking in CLI to give user's early feedback on whether they can execute certain commands or not.
This is an in-progress DRAFT.
Linked Issues
#874
Checklist