fix: fix DSN regex to handle port numbers

DeepSourceCorp · Feb 2, 2024 · 76a5069 · 76a5069
1 parent 8a15f31
commit 76a5069
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/command/report/dsn.go b/command/report/dsn.go
@@ -14,7 +14,7 @@ type DSN struct {
 }
 
 func NewDSN(raw string) (*DSN, error) {
-	dsnPattern := regexp.MustCompile(`^(https?)://([^:@]+)@([^:/]+)`)
+	var dsnPattern = regexp.MustCompile(`^(https?)://([^:@]+)@([^:/]+(?:\:\d+)?)`)
 	matches := dsnPattern.FindStringSubmatch(raw)
 	if len(matches) != 4 {
 		return nil, ErrInvalidDSN

diff --git a/command/report/dsn_test.go b/command/report/dsn_test.go
@@ -27,6 +27,17 @@ func TestNewDSN(t *testing.T) {
 			},
 			wantErr: nil,
 		},
+		{
+			name: "valid DSN with port",
+			args: args{
+				raw: "http://f59a44307@localhost:8081",
+			},
+			want: &DSN{
+				Token:    "f59a44307",
+				Host:     "localhost:8081",
+				Protocol: "http",
+			},
+		},
 		{
 			name: "invalid DSN no http",
 			args: args{