Add unit test for transform #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicoRenaud
requested changes
Oct 25, 2019
pdb2sql/transform.py
Outdated
| xyz = rotation_matrix(xyz, mat) | ||
| _update(db, xyz, **kwargs) | ||
|
|
||
| def rotation_matrix(xyz, rot_mat, center=None): |
There was a problem hiding this comment.
that function name implies it returns the rotation matrix. I would change it to rotate or apply_rotation.
| @@ -0,0 +1,172 @@ | |||
| import unittest | |||
There was a problem hiding this comment.
Great for the test ! That was definitely missing :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.