This repository has been archived by the owner on Mar 22, 2024. It is now read-only.
Update NeuralNet.py #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
manonreau
commented
Nov 25, 2020
manonreau
commented
- fix some export bugs.
NicoRenaud
approved these changes
Nov 27, 2020
Comment on lines
348
to
353
| count = 0 | ||
| hdf5_name = hdf5.split('.')[0] | ||
| while os.path.exists(fname) : | ||
| count += 1 | ||
| hdf5 = hdf5.split('.')[0] | ||
| hdf5 = '{}_{:03d}.hdf5'.format(hdf5, count) | ||
| hdf5 = '{}_{:03d}.hdf5'.format(hdf5_name, count) | ||
| fname = os.path.join(self.outdir, hdf5) |
There was a problem hiding this comment.
you could consider putting that in a staticmethod or external function as it appears at several places :)
There was a problem hiding this comment.
in general code duplication should be avoided as it makes the code difficult to maintain. In this case it's not a big deal of course :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.