Skip to content

Commit

Permalink
Remove unused dependency on humanize
Browse files Browse the repository at this point in the history
There was a release version that was newer, but this one was also
pulling in an old version of clojure.math/numeric-tower, which
produced a warning about `abs` being shadowed. Getting rid of it
showed we were relying on that implicit dependency in some code, but
we can replace that with the new, faster, tinier clojure.math in the
core library.
  • Loading branch information
brunchboy committed Oct 1, 2023
1 parent 22a3f77 commit 35dbcc5
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ Nothing so far.
actually needs Java 1.9 or later. The fact that nobody has run into
this issue suggests nobody is using such ancient versions anyway, so
this could perhaps be removed.
- Removed some libraries that were not actually used any more, saving
some file size.

## [7.2.0] - 2023-08-13

Expand Down
5 changes: 2 additions & 3 deletions project.clj
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,12 @@
:url "https://www.eclipse.org/legal/epl-2.0/"}
:aot [beat-link-trigger.BeatLinkTrigger beat-link-trigger.TexturedRaven]
:dependencies [[org.clojure/clojure "1.11.1"]
[org.clojure/core.async "1.6.673"]
[org.clojure/core.async "1.6.681"]
[org.clojure/data.csv "1.0.1"]
[org.clojure/tools.cli "1.0.214"]
[org.clojure/tools.cli "1.0.219"]
[beat-carabiner "1.0.0"]
[cheshire "5.11.0"]
[cider/cider-nrepl "0.30.0"]
[clojure-humanize "0.2.2"]
[clj-commons/pomegranate "1.2.23"]
[com.cemerick/url "0.1.1"]
[com.fifesoft/rstaui "3.3.1"]
Expand Down
4 changes: 2 additions & 2 deletions src/beat_link_trigger/show_phrases.clj
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
swap-show! swap-phrase! swap-phrase-runtime!
phrase-runtime-info get-chosen-output no-output-chosen]]
[beat-link-trigger.util :as util]
[clojure.math.numeric-tower :as math]
[clojure.math :as math]
[clojure.set :as set]
[clojure.string :as str]
[overtone.midi :as midi]
Expand Down Expand Up @@ -1475,7 +1475,7 @@ editor windows, in their cue canvases as well."
"Custom"
(let [result (run-phrase-function show phrase-trigger :custom-enabled status false)]
(if (number? result)
(let [weight (long (min (math/round result) 1000))]
(let [weight (min (math/round result) 1000)]
(when (pos? weight) weight))
(when result 1)))

Expand Down

0 comments on commit 35dbcc5

Please sign in to comment.