Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple data types #292

Merged
merged 4 commits into from
Aug 27, 2023
Merged

Add support for multiple data types #292

merged 4 commits into from
Aug 27, 2023

Conversation

edenhaus
Copy link
Contributor

@edenhaus edenhaus commented Aug 17, 2023

Restructure all commands and messages to support multiple data types.

@edenhaus edenhaus changed the title Add support for xml based commands Add support for multiple data types Aug 23, 2023
@edenhaus edenhaus added the pr: Breaking Change Pull request with braking changes label Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #292 (a0f7051) into main (15b97b3) will increase coverage by 0.68%.
The diff coverage is 98.42%.

@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
+ Coverage   73.25%   73.93%   +0.68%     
==========================================
  Files          49       51       +2     
  Lines        2131     2191      +60     
  Branches      422      438      +16     
==========================================
+ Hits         1561     1620      +59     
- Misses        520      521       +1     
  Partials       50       50              
Files Changed Coverage Δ
deebot_client/commands/json/const.py 100.00% <ø> (ø)
deebot_client/commands/json/play_sound.py 80.00% <ø> (ø)
deebot_client/commands/json/relocation.py 80.00% <ø> (ø)
deebot_client/vacuum_bot.py 74.48% <50.00%> (ø)
deebot_client/message.py 85.04% <89.47%> (-0.22%) ⬇️
deebot_client/command.py 90.36% <100.00%> (+0.61%) ⬆️
deebot_client/commands/__init__.py 100.00% <100.00%> (ø)
deebot_client/commands/json/__init__.py 100.00% <100.00%> (ø)
deebot_client/commands/json/advanced_mode.py 100.00% <100.00%> (ø)
deebot_client/commands/json/battery.py 100.00% <100.00%> (ø)
... and 29 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edenhaus edenhaus marked this pull request as ready for review August 24, 2023 19:11
@edenhaus
Copy link
Contributor Author

@sandervankasteel What do you think about this change?

The implementation of which model supports what is coming in a follow-up PR.

@sandervankasteel
Copy link
Contributor

@sandervankasteel What do you think about this change?

The implementation of which model supports what is coming in a follow-up PR.

For an initial base of the new architecture, I can definitely see this working! 😄

@sandervankasteel
Copy link
Contributor

@edenhaus what the your proposed action plan for this?

Do you wanna merge this PR + plus the functionality for model specific implementations first and then I update my PR for the new functionality? Or would be better for me to already start implemented the XML commands based on this PR?

@edenhaus edenhaus changed the base branch from main to dev August 27, 2023 22:57
@edenhaus edenhaus merged commit 839dee9 into dev Aug 27, 2023
6 checks passed
@edenhaus edenhaus deleted the xml branch August 27, 2023 22:58
@edenhaus
Copy link
Contributor Author

@sandervankasteel I have created the new branch dev, use this branch as base for your changes. You can start to implemented the new commands 😊

In the meantime I work on the model specific support PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: Breaking Change Pull request with braking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants