-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple data types #292
Conversation
Codecov Report
@@ Coverage Diff @@
## main #292 +/- ##
==========================================
+ Coverage 73.25% 73.93% +0.68%
==========================================
Files 49 51 +2
Lines 2131 2191 +60
Branches 422 438 +16
==========================================
+ Hits 1561 1620 +59
- Misses 520 521 +1
Partials 50 50
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@sandervankasteel What do you think about this change? The implementation of which model supports what is coming in a follow-up PR. |
For an initial base of the new architecture, I can definitely see this working! 😄 |
@edenhaus what the your proposed action plan for this? Do you wanna merge this PR + plus the functionality for model specific implementations first and then I update my PR for the new functionality? Or would be better for me to already start implemented the XML commands based on this PR? |
@sandervankasteel I have created the new branch In the meantime I work on the model specific support PR |
Restructure all commands and messages to support multiple data types.