Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dispatching issues with get_basis on cartesian coordinates #294

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Fix dispatching issues with get_basis on cartesian coordinates #294

merged 1 commit into from
Jun 18, 2024

Conversation

kburns
Copy link
Member

@kburns kburns commented Jun 18, 2024

Fixes #293

@kburns kburns requested a review from lecoanet June 18, 2024 21:53
lecoanet
lecoanet reviewed Jun 18, 2024
View reviewed changes
Copy link
Member

@lecoanet lecoanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Stephane Labrosse's script, and this fixes his issue.

@lecoanet lecoanet merged commit f5c07ab into master Jun 18, 2024
@lecoanet lecoanet deleted the getbasis branch June 19, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lecoanet lecoanet lecoanet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CartesianGradient / Laplacian bug
2 participants
@kburns @lecoanet