fixes regions not being removed in scenarios with many regions

DecwLK · Mar 10, 2024 · 206c7af · 206c7af
1 parent 1988169
commit 206c7af
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/main/java/org/gecko/viewmodel/EditorViewModel.java b/src/main/java/org/gecko/viewmodel/EditorViewModel.java
@@ -111,6 +111,7 @@ public void updateRegions() throws ModelException {
             .map(element -> (StateViewModel) element)
             .collect(Collectors.toSet());
         for (RegionViewModel regionViewModel : regionViewModels) {
+            regionViewModel.clearStates();
             for (StateViewModel stateViewModel : stateViewModels) {
                 regionViewModel.checkStateInRegion(stateViewModel);
                 regionViewModel.updateTarget();

diff --git a/src/main/java/org/gecko/viewmodel/RegionViewModel.java b/src/main/java/org/gecko/viewmodel/RegionViewModel.java
@@ -64,6 +64,10 @@ public void removeState(@NonNull StateViewModel state) {
         statesProperty.remove(state);
     }
 
+    public void clearStates() {
+        statesProperty.clear();
+    }
+
     @Override
     public Object accept(@NonNull PositionableViewModelElementVisitor visitor) {
         return visitor.visit(this);
@@ -86,7 +90,7 @@ public Color getColor() {
     }
 
     /**
-     * Checks if the given state is in the region and adds it to the region if it is or removes it if it is not.
+     * Checks if the given state is in the region and adds it to the region if it is.
      *
      * @param state the state to check
      */
@@ -98,8 +102,6 @@ public void checkStateInRegion(StateViewModel state) {
                 state.getSize().getY());
         if (regionBound.intersects(stateBound)) {
             addState(state);
-        } else {
-            removeState(state);
         }
     }