Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sg 1060 yolo nas pose #1611

Merged
merged 410 commits into from
Nov 6, 2023
Merged

Feature/sg 1060 yolo nas pose #1611

merged 410 commits into from
Nov 6, 2023

Conversation

BloodAxe
Copy link
Contributor

@BloodAxe BloodAxe commented Nov 6, 2023 •
edited
Loading

This PR adds a final pieces of YoloNAS-Pose:

  • Pretrained weights
  • Integration tests
  • Notebooks to run offline COCOEval
  • Training recipes
  • Docs
  • Model zoo

@BloodAxe
crowdpose_yolo_nas_pose_s
e2f7238
@BloodAxe
crowdpose_yolo_nas_pose_s
af7fd3a
@BloodAxe
crowdpose_yolo_nas_pose_s
63e0db1
@BloodAxe
crowdpose_yolo_nas_pose_s
ba2e1fc
@BloodAxe
coco2017_yolo_nas_pose_s_ema_less_mosaic
4dfd98f
@BloodAxe
coco2017_yolo_nas_pose_s_less_mosaic
471d3f4
@BloodAxe
coco2017_yolo_nas_pose_s_ema_less_mosaic_higher_final_lr_fp32
d308ed3
@BloodAxe
coco2017_yolo_nas_pose_s_ema_less_mosaic_higher_final_lr_fp32
9d81f9f
@BloodAxe
coco2017_yolo_nas_pose_s_ema_less_mosaic_lr_focal
934e7f0
@BloodAxe
shared head
1312707
@BloodAxe
YoloNASPoseBoxesPostPredictionCallback
7003d7a
@BloodAxe
New head design
7123057
@BloodAxe
Another recipe with less zoom out, no crowd images
7465649
@BloodAxe
Another recipe with less zoom out, no crowd images
e421113
@BloodAxe
Another recipe with less zoom out, no crowd images
a78c9b3
@BloodAxe
coco2017_yolo_nas_pose_shared_s_ema_less_mosaic_lr_bce_local
9d05290
@BloodAxe
coco2017_yolo_nas_pose_shared_s_ema_less_mosaic_lr_bce_local
c2fae2d
@BloodAxe
Update scores
1dd5382
@BloodAxe
Cleanup old configs, keep one config that gives best AP score
3138c77
@BloodAxe
Shortened recipe
716e2ec
@BloodAxe
coco2017_yolo_nas_pose_shared_s_384_short
bd94c93
@BloodAxe
Tune short recipe
a4d84fe
@BloodAxe
Tune short recipe
70128f6
@BloodAxe
Tune short recipe
16ba7e5
@BloodAxe
Tune short recipe
df02b12
@BloodAxe
Merge branch 'master' into feature/SG-1060-yolo-nas-pose-respect-crowd
82bdf88
@BloodAxe
coco2017_yolo_nas_pose_s_local
dc9e1e5
@BloodAxe
Update settings of crowd_annotations_action to mask_as_normal since t…
9242e97 
…his is the setting we got the best result with
@BloodAxe
coco2017_yolo_nas_pose_shared_s_local
10c1066
@BloodAxe
Update default params
39987e2
@BloodAxe BloodAxe marked this pull request as ready for review November 6, 2023 08:24
ofrimasad
ofrimasad reviewed Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very impressive work @BloodAxe !
I have a few minor comments. Maybe we can clean some prints from the md files.

YOLONAS-POSE.md Outdated Show resolved Hide resolved
YOLONAS-POSE.md Outdated Show resolved Hide resolved
documentation/source/models_export_pose.md Show resolved Hide resolved
documentation/source/models_export_pose.md Outdated Show resolved Hide resolved
documentation/source/models_export_pose.md Outdated Show resolved Hide resolved
Louis-Dupont
Louis-Dupont previously approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I left a few non blocking comments/questions

Makefile Show resolved Hide resolved
YOLONAS-POSE.md Show resolved Hide resolved
src/super_gradients/training/transforms/keypoints/keypoints_reverse_image_channels.py Outdated Show resolved Hide resolved
shaydeci
shaydeci previously approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe dismissed stale reviews from shaydeci and Louis-Dupont via c7c1be5 November 6, 2023 09:56
ofrimasad
ofrimasad approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit 46cdc18 into master Nov 6, 2023
8 checks passed
@BloodAxe BloodAxe deleted the feature/SG-1060-yolo-nas-pose branch November 6, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Louis-Dupont Louis-Dupont Louis-Dupont left review comments

@ofrimasad ofrimasad ofrimasad approved these changes

@shaydeci shaydeci shaydeci left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BloodAxe @ofrimasad @Louis-Dupont @shaydeci