fix: make open property of VtmnAccordion reactive #1461
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes description
This is a bugfix to the VtmnAccordion component. The
open
prop was binded in the details element.Context
The previous implementation only allows us to pass the
open
prop down, but changes are not reflected. In particular, we cannot let the parent of the VtmnAccordion know when it is open and when not. So this is just a missing feature, but: there is also a bug in the previous implementation: the linearia-expanded={open}
means that thearia-expanded
property is always set to the initial value. It will never be changed.When the accordion is closed, it does not have the
open
prop and we havearia-expanded=false
, which is correct:But when it is opened, the
open
prop is added, butaria-expanded=false
stays.This pull request fixes this bug.
Checklist
design-system-core-team-design
GitHub team.Does this introduce a breaking change?