-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit intro based on reviews #134
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
nbs/introduction.ipynb
Outdated
@@ -89,147 +89,147 @@ | |||
"name": "stderr", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory, we usually say that a datalog/rgxlog query is trying to find all instantiations of the free variables that satisfy the query.
And this is why if we have a query with no free variables, we get an empty set of instantiations if its true and no such set if its false.
Perhaps you can present queries using the instantiation
notation and then the explanation here will be easier to understand.
Reply via ReviewNB
nbs/introduction.ipynb
Outdated
@@ -89,147 +89,147 @@ | |||
"name": "stderr", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think this "empty table" will persist in later versions, and are queries even saved in the DB?
What the users should know here is that we save the facts in the database, the rules' logic is saved seperately and only evaluated lazily (on demand).
One a query is issued, the engines uses the rules to derive all possible solutions from the existing facts that would satisfy the query.
Reply via ReviewNB
nbs/introduction.ipynb
Outdated
@@ -89,147 +89,147 @@ | |||
"name": "stderr", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some comments
@@ -85,152 +85,153 @@ | |||
"execution_count": null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -85,152 +85,153 @@ | |||
"execution_count": null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rewrite the second sentense "A query is essentially a way to retrieve specific information from a dataset, i.e it finds all instantiations of the free variables that satisfy the query. " the second part of the sentence is not an example of the first part, so the use of "ie" is incorrect.
Maybe just say that querying in rgxlog uses the same synatx and semantics as DataLog. Under said semantics, we try to find all instantiations of free variables that satisfy the queried relation.
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
address my 2 small comments and then you can merge,
We edited the introduction.ipynb file based on the feedback we received from new people combined with Ahmad & Mahmoud's feedback.
Here are the list of questions/ things to clarify that we received:
So we edited the introduction file and added explanations to answer all of the above questions