Fixedbug to handle Union type #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xSalman
requested review from
edlau,
petrogko,
dabfleming,
Niennienzz,
SteveGBanton and
elau-dt
dabfleming
reviewed
Apr 24, 2018
| @@ -176,3 +188,9 @@ func (r *Resolver) User(ctx context.Context, args struct{ Id string }) (user, er | |||
| err := fmt.Errorf("user with id=%s does not exist", args.Id) | |||
| return user{}, err | |||
| } | |||
|
|
|||
| func (r *Resolver) Search(ctx context.Context, args struct{ Text string }) ([]*searchResult, error) { | |||
There was a problem hiding this comment.
Terrible example of search, but not exactly a blocker I suppose.
There was a problem hiding this comment.
example is updated to be somewhat better
dabfleming
approved these changes
Apr 24, 2018
Niennienzz
approved these changes
Apr 24, 2018
petrogko
approved these changes
Apr 24, 2018
0xSalman
force-pushed
the
bug-union-type
branch
from
3bc3e7b to
3c3c15b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bug to handle graphql
Uniontype when using field resolvers. The actual change is one lineFor testing, just run
./src/example/social/server.goand try query forSearch. The search text has no bearing on the response