Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helperText is just for errors #22

Open
dbonabhealth opened this issue Aug 20, 2019 · 1 comment · May be fixed by #23
Open

helperText is just for errors #22

dbonabhealth opened this issue Aug 20, 2019 · 1 comment · May be fixed by #23

Comments

@dbonabhealth
Copy link

In TextField, there is this code: helperText={showError ? meta.error || meta.submitError : undefined}
that basically ignores any initial value of helperText.

Is there any reason not to have the code like:
helperText={showError ? meta.error || meta.submitError : rest.helperText} ...or something to that effect?

I apologize if I violated your guidelines for requesting a feature.

alirezamirian added a commit to alirezamirian/final-form-material-ui that referenced this issue Aug 23, 2019
@alirezamirian alirezamirian linked a pull request Aug 23, 2019 that will close this issue
@optyler
Copy link

optyler commented Oct 25, 2019

IMO, we need to split this two things appart.

The component used is MuiFormHelperText and display error messages, then, the variant prop should be error right ?
But if we use the helper text as a real helper, the variant error should not be used...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants