-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jellyfish-api-core): add masternode isAppliedCustomTransaction RPC #957
Conversation
Code Climate has analyzed commit bf27cd8 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #957 +/- ##
==========================================
- Coverage 95.53% 94.62% -0.92%
==========================================
Files 158 158
Lines 4820 4822 +2
Branches 634 634
==========================================
- Hits 4605 4563 -42
- Misses 208 246 +38
- Partials 7 13 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
packages/jellyfish-api-core/__tests__/category/masternode/isAppliedCustomTransaction.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/masternode/isAppliedCustomTransaction.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/masternode/isAppliedCustomTransaction.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some comments.
packages/jellyfish-api-core/__tests__/category/masternode/isAppliedCustomTransaction.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/masternode/isAppliedCustomTransaction.test.ts
Outdated
Show resolved
Hide resolved
✔️ Deploy Preview for jellyfish-defi ready! 🔨 Explore the source changes: 3472e0f 🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/61dd063fc91e830007619a56 😎 Browse the preview: https://deploy-preview-957--jellyfish-defi.netlify.app |
What this PR does / why we need it:
Checks that custom transaction was affected on chain
Which issue(s) does this PR fixes?:
Added isAppliedCustomTransaction rpc as part of ongoing #48