Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jellyfish-api-core): add masternode isAppliedCustomTransaction RPC #957

Merged
merged 5 commits into from
Feb 23, 2022

Conversation

chanakasameera
Copy link
Contributor

What this PR does / why we need it:
Checks that custom transaction was affected on chain

Which issue(s) does this PR fixes?:
Added isAppliedCustomTransaction rpc as part of ongoing #48

@codeclimate
Copy link

codeclimate bot commented Jan 10, 2022

Code Climate has analyzed commit bf27cd8 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #957 (bf27cd8) into main (36712ed) will decrease coverage by 0.91%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #957      +/-   ##
==========================================
- Coverage   95.53%   94.62%   -0.92%     
==========================================
  Files         158      158              
  Lines        4820     4822       +2     
  Branches      634      634              
==========================================
- Hits         4605     4563      -42     
- Misses        208      246      +38     
- Partials        7       13       +6     
Impacted Files Coverage Δ
...ages/jellyfish-api-core/src/category/masternode.ts 100.00% <100.00%> (ø)
apps/ocean-api/src/modules/BlockchainCppModule.ts 50.00% <0.00%> (-38.24%) ⬇️
...s/ocean-api/src/controllers/filters/ErrorFilter.ts 6.55% <0.00%> (-37.71%) ⬇️
packages/jellyfish-address/src/p2pkh.ts 66.66% <0.00%> (-33.34%) ⬇️
apps/ocean-api/src/modules/ActuatorModule.ts 66.66% <0.00%> (-33.34%) ⬇️
...ps/ocean-api/src/controllers/ActuatorController.ts 66.66% <0.00%> (-33.34%) ⬇️
packages/jellyfish-crypto/src/bech32.ts 79.16% <0.00%> (-20.84%) ⬇️
...transaction-builder/src/txn/txn_builder_oracles.ts 87.50% <0.00%> (-12.50%) ⬇️
...ages/jellyfish-api-core/src/category/blockchain.ts 87.87% <0.00%> (-12.13%) ⬇️
.../src/containers/RegTestContainer/ContainerGroup.ts 87.23% <0.00%> (-8.52%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36712ed...bf27cd8. Read the comment docs.

@chanakasameera chanakasameera changed the title feat(jellyfish-api-core): add isAppliedCustomTransaction RPC feat(jellyfish-api-core): add masternode isAppliedCustomTransaction RPC Jan 10, 2022
chee-chyuan
chee-chyuan previously approved these changes Jan 10, 2022
Copy link
Contributor

@chee-chyuan chee-chyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@surangap surangap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments.

@netlify
Copy link

netlify bot commented Jan 11, 2022

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: 3472e0f

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/61dd063fc91e830007619a56

😎 Browse the preview: https://deploy-preview-957--jellyfish-defi.netlify.app

canonbrother
canonbrother previously approved these changes Jan 12, 2022
@fuxingloh fuxingloh merged commit ddc6b7f into main Feb 23, 2022
@fuxingloh fuxingloh deleted the chanakasameera/rpc-isappliedcustomtx branch February 23, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants