-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ocean-api-client): add ocean-api
client core
#909
Conversation
Code Climate has analyzed commit addbfd6 and detected 0 issues on this pull request. View more on Code Climate. |
✔️ Deploy Preview for jellyfish-defi ready! 🔨 Explore the source changes: addbfd6 🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/61c2e48995cd880007f7ee42 😎 Browse the preview: https://deploy-preview-909--jellyfish-defi.netlify.app |
ocean-api
client core
Codecov Report
@@ Coverage Diff @@
## main #909 +/- ##
==========================================
- Coverage 96.62% 96.11% -0.51%
==========================================
Files 134 141 +7
Lines 4384 4505 +121
Branches 570 584 +14
==========================================
+ Hits 4236 4330 +94
- Misses 148 175 +27
Continue to review full report at Codecov.
|
Co-authored-by: chee-chyuan <[email protected]>
* Added getFutureSwapBlock rpc to whitelist Signed-off-by: Suraj Auwal <[email protected]> * Fixed incorrect casing. Signed-off-by: Suraj Auwal <[email protected]>
What this PR does / why we need it:
DeFiChain Ocean API, next^2 generation API for building scalable Native DeFi Apps.
This is the foundational setup for Ocean API development integration into Jellyfish. Have been working on it for the past 3 weeks chipping off integration and migrating code slowly. This PR introduces 4 key concepts/packages with separation of concerns. Although the implementation example is small, they are fully featured working and tested.
Motivation
As part of #580 consolidation efforts. We had multiple projects that were extensions of the jellyfish project. The separated projects allowed us to move quickly initially but proves to be a bottleneck when it comes to development.
By including Ocean API development with jellyfish, it creates a better synergy of DeFiChain open source development across concerns. Singular versioning, source of truth, documentation of entirety of defichain via jellyfish.defichain.com.
@defichain/ocean-api-client
The official JS client for ocean-api. As the development of ocean-api client and server are closely intertwined, this allows the project to move iteratively together. With them packaged together within the same repo, the server and client can be released together. This allows us to be the consumer of our own client implementation. Testing each server endpoint directly with
ocean-api-client
, dogfooding at the maximum.