Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arithmetic opcodes #512

Merged
merged 4 commits into from
Jul 29, 2021
Merged

Add arithmetic opcodes #512

merged 4 commits into from
Jul 29, 2021

Conversation

jingyi2811
Copy link
Contributor

@jingyi2811 jingyi2811 commented Jul 28, 2021

What kind of PR is this?:
/kind feature

What this PR does / why we need it:
Adds arithmetic opcodes mentioned in #107

Which issue(s) does this PR fixes?:
Fixes missing opcodes in #107

Additional comments?:

@codeclimate
Copy link

codeclimate bot commented Jul 28, 2021

Code Climate has analyzed commit 44825f5 and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

github-actions bot commented Jul 28, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/index.umd.js 21.86 KB (0%) 438 ms (0%) 196 ms (-5.35% 🔽) 633 ms

@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #512 (44825f5) into main (25bc6da) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #512      +/-   ##
==========================================
+ Coverage   97.35%   97.42%   +0.07%     
==========================================
  Files         108      109       +1     
  Lines        3101     3187      +86     
  Branches      385      385              
==========================================
+ Hits         3019     3105      +86     
  Misses         82       82              
Impacted Files Coverage Δ
...ges/jellyfish-transaction/src/script/arithmetic.ts 100.00% <100.00%> (ø)
packages/jellyfish-transaction/src/script/index.ts 100.00% <100.00%> (ø)
...ckages/jellyfish-transaction/src/script/mapping.ts 96.77% <100.00%> (+0.03%) ⬆️
packages/jellyfish-api-core/src/category/spv.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25bc6da...44825f5. Read the comment docs.

@jingyi2811 jingyi2811 marked this pull request as ready for review July 28, 2021 13:42
@aikchun aikchun requested review from aikchun and removed request for aikchun July 29, 2021 02:34
@netlify
Copy link

netlify bot commented Jul 29, 2021

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: 44825f5

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/61021a36dc23300008c233b2

😎 Browse the preview: https://deploy-preview-512--jellyfish-defi.netlify.app

@jingyi2811 jingyi2811 changed the title Add numeric opcodes Add arithmetics opcodes Jul 29, 2021
@jingyi2811 jingyi2811 changed the title Add arithmetics opcodes Add arithmetic opcodes Jul 29, 2021
@fuxingloh fuxingloh merged commit 956f990 into main Jul 29, 2021
@fuxingloh fuxingloh deleted the jimmy/opcodes-numeric branch July 29, 2021 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants