Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added vote RPC #487

Merged
merged 11 commits into from
Jul 29, 2021
Merged

Added vote RPC #487

merged 11 commits into from
Jul 29, 2021

Conversation

Jouzo
Copy link
Contributor

@Jouzo Jouzo commented Jul 23, 2021

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Added vote RPC

Which issue(s) does this PR fixes?:

Fixes part of #458

@codeclimate
Copy link

codeclimate bot commented Jul 23, 2021

Code Climate has analyzed commit 2ba4a9b and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Jul 23, 2021

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: 2ba4a9b

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/61025753e231ef0007e3fbe7

😎 Browse the preview: https://deploy-preview-487--jellyfish-defi.netlify.app

@github-actions
Copy link

github-actions bot commented Jul 23, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/index.umd.js 22.11 KB (+0.43% 🔺) 443 ms (+0.43% 🔺) 220 ms (+11.28% 🔺) 662 ms

@Jouzo Jouzo marked this pull request as ready for review July 29, 2021 07:23
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #487 (2ba4a9b) into main (bd19f65) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #487   +/-   ##
=======================================
  Coverage   97.44%   97.45%           
=======================================
  Files         109      109           
  Lines        3211     3217    +6     
  Branches      389      391    +2     
=======================================
+ Hits         3129     3135    +6     
  Misses         82       82           
Impacted Files Coverage Δ
...ages/jellyfish-api-core/src/category/governance.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd19f65...2ba4a9b. Read the comment docs.

@fuxingloh fuxingloh merged commit 81dec2e into main Jul 29, 2021
@fuxingloh fuxingloh deleted the jouzo/vote branch July 29, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants