jellyfish-wallet should provide non-hd WalletNode by default

[fuxingloh]

What kind of PR is this?:

/kind refactor

What this PR does / why we need it:

To allow non-HdWallet use cases and implementations as not all wallet implementations are HD, we should not enforce HD Nodes.

[codeclimate]

Code Climate has analyzed commit 512e53f and detected 0 issues on this pull request.

View more on Code Climate.

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
packages/jellyfish/dist/index.umd.js	21.3 KB (0%)	426 ms (0%)	169 ms (-0.54% 🔽)	595 ms

[codecov]

Codecov Report

Merging #453 (512e53f) into main (00986ae) will increase coverage by 4.50%.
The diff coverage is 98.03%.

@@            Coverage Diff             @@
##             main     #453      +/-   ##
==========================================
+ Coverage   92.98%   97.48%   +4.50%     
==========================================
  Files          10       98      +88     
  Lines         171     2904    +2733     
  Branches       19      288     +269     
==========================================
+ Hits          159     2831    +2672     
- Misses         12       73      +61     

Impacted Files	Coverage Δ
...ackages/jellyfish-transaction-builder/src/index.ts	100.00% <ø> (ø)
...llyfish-transaction-builder/src/txn/txn_builder.ts	96.15% <ø> (ø)
...transaction-builder/src/txn/txn_builder_account.ts	100.00% <ø> (ø)
...ish-transaction-builder/src/txn/txn_builder_dex.ts	100.00% <ø> (ø)
...h-transaction-builder/src/txn/txn_builder_error.ts	100.00% <ø> (ø)
...ransaction-builder/src/txn/txn_builder_liq_pool.ts	100.00% <ø> (ø)
...transaction-builder/src/txn/txn_builder_oracles.ts	100.00% <ø> (ø)
...sh-transaction-builder/src/txn/txn_builder_utxo.ts	100.00% <ø> (ø)
...s/jellyfish-transaction-builder/src/txn/txn_fee.ts	100.00% <ø> (ø)
...kages/jellyfish-transaction-signature/src/index.ts	100.00% <ø> (ø)
... and 144 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b39bb0f...512e53f. Read the comment docs.

[monstrobishi]

Since we are working on naming here, I'm not sure if I understand the term non-hd wallet node, as the term HD node is very specific to HD wallets?

[monstrobishi]

https://arshbot.medium.com/hd-wallets-explained-from-high-level-to-nuts-and-bolts-9a41545f5b0

Quote:
Technically speaking, Hierarchical Deterministic Wallets are a tree structure where each node has an extended private and public key. Any node can have any number of children. Meaning a master key could regenerate 10 accounts in 10 different currencies each with a very high number of addresses. I chose 10 as an arbitrary number, the number could be as large as you’d like.

Imo it's either an HD Node or a key pair, a node without the tree is no longer a node

[monstrobishi]

Perhaps call it WalletEllipticPair or ExtendedEllipticPair

[fuxingloh]

Perhaps call it WalletEllipticPair or ExtendedEllipticPair

Make sense, let's call it WalletEllipticPair? can you make the change?

[monstrobishi]

Sure

[ivan-zynesis]

Looking at the implementation again. WalletHdNode do not really make sense, as how it can perform direct getScript() and getAddress()

multiple node derivation will be inside HdWalletNodeProvider<WalletNode>, maybe can just remove WalletHdNode entirely.

[fuxingloh]

looks good, let's get this merged and we can create a release to sync whale