Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@defichain/testing createToken to return id number #234

Merged
merged 2 commits into from
May 17, 2021

Conversation

fuxingloh
Copy link
Contributor

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Testing module token.createToken to return number id of the created token for testing QOL.

@github-actions
Copy link

github-actions bot commented May 17, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 18.93 KB (0%) 379 ms (0%) 150 ms (-10.67% 🔽) 528 ms

@fuxingloh fuxingloh changed the title testing createToken to return id number @defichain/testing createToken to return id number May 17, 2021
@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #234 (896fcb7) into main (dc80d46) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #234   +/-   ##
=======================================
  Coverage   96.22%   96.22%           
=======================================
  Files          66       66           
  Lines        1696     1697    +1     
  Branches      234      234           
=======================================
+ Hits         1632     1633    +1     
  Misses         64       64           
Impacted Files Coverage Δ
packages/testing/src/token.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc80d46...896fcb7. Read the comment docs.

@fuxingloh fuxingloh marked this pull request as ready for review May 17, 2021 05:21
@fuxingloh fuxingloh requested a review from canonbrother as a code owner May 17, 2021 05:21
@fuxingloh fuxingloh enabled auto-merge (squash) May 17, 2021 05:22
@fuxingloh fuxingloh merged commit 61f46e9 into main May 17, 2021
@fuxingloh fuxingloh deleted the fuxingloh/testing-create-token-return-id branch May 17, 2021 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants