feat(jellyfish-api-core): add verifyMessage and signMessageWithPrivKey RPCs #1905
+149
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shohamc1
requested review from
fuxingloh,
canonbrother and
ivan-zynesis
as code owners
github-actions
bot
added
apps/website
area/packages
kind/feature
|
Code Climate has analyzed commit 4c8e3ac and detected 0 issues on this pull request. View more on Code Climate. |
✅ Deploy Preview for jellyfishsdk ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportBase: 87.31% // Head: 94.13% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1905 +/- ##
==========================================
+ Coverage 87.31% 94.13% +6.81%
==========================================
Files 358 367 +9
Lines 10526 10775 +249
Branches 1340 1376 +36
==========================================
+ Hits 9191 10143 +952
+ Misses 1259 607 -652
+ Partials 76 25 -51
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Docker build preview for jellyfish/apps is ready! Built with commit 1a68157
You can also get an immutable image with the commit hash
|
shancht
suggested changes
Jan 11, 2023
packages/jellyfish-api-core/__tests__/category/misc/signMessageWithPrivKey.test.ts
Outdated
Show resolved
Hide resolved
marktanrj
previously approved these changes
Jan 12, 2023
packages/jellyfish-api-core/__tests__/category/misc/signMessageWithPrivKey.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/misc/verifyMessage.test.ts
Outdated
Show resolved
Hide resolved
shancht
approved these changes
Jan 12, 2023
fuxingloh
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds verifyMessage and signMessageWithPrivKey RPCs and tests.
Which issue(s) does this PR fixes?:
Fixes part of #48