Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jellyfish-api-core): add invalidateBlock and reconsiderBlock RPCs #1904

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

shohamc1
Copy link
Contributor

@shohamc1 shohamc1 commented Dec 5, 2022

What this PR does / why we need it:

Adds invalidateBlock and reconsiderBlock RPCs and tests.

Which issue(s) does this PR fixes?:

Fixes part of #48

@codeclimate
Copy link

codeclimate bot commented Dec 5, 2022

Code Climate has analyzed commit 5a96f6b and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Dec 5, 2022

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit 5a96f6b
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/63d0c01a36f2fa0009a8aa67
😎 Deploy Preview https://deploy-preview-1904--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 89.93% // Head: 93.01% // Increases project coverage by +3.07% 🎉

Coverage data is based on head (5a96f6b) compared to base (7d9b142).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1904      +/-   ##
==========================================
+ Coverage   89.93%   93.01%   +3.07%     
==========================================
  Files         366      364       -2     
  Lines       10985    10974      -11     
  Branches     1432     1432              
==========================================
+ Hits         9879    10207     +328     
+ Misses       1045      738     -307     
+ Partials       61       29      -32     
Impacted Files Coverage Δ
...ages/jellyfish-api-core/src/category/blockchain.ts 100.00% <100.00%> (+8.88%) ⬆️
...playground-api/src/controllers/WalletController.ts 26.19% <0.00%> (-73.81%) ⬇️
packages/playground-api-client/src/apis/Wallet.ts 16.66% <0.00%> (-66.67%) ⬇️
...transaction-builder/src/txn/txn_builder_account.ts 51.35% <0.00%> (-48.65%) ⬇️
packages/whale-api-client/src/api/prices.ts 26.08% <0.00%> (-47.83%) ⬇️
apps/whale-api/src/module.api/price.controller.ts 43.13% <0.00%> (-27.46%) ⬇️
apps/whale-api/src/module.model/price.ticker.ts 71.42% <0.00%> (-14.29%) ⬇️
apps/whale-api/src/module.model/masternode.ts 85.71% <0.00%> (-14.29%) ⬇️
...h-transaction-builder/src/txn/txn_builder_vault.ts 88.23% <0.00%> (-11.77%) ⬇️
.../src/containers/RegTestContainer/ContainerGroup.ts 85.41% <0.00%> (-10.42%) ⬇️
... and 54 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Docker build preview for jellyfish/apps is ready!

Built with commit 570fe64

  • ghcr.io/jellyfishsdk/legacy-api:pr-1904
  • ghcr.io/jellyfishsdk/playground-api:pr-1904
  • ghcr.io/jellyfishsdk/status-api:pr-1904
  • ghcr.io/jellyfishsdk/whale-api:pr-1904

You can also get an immutable image with the commit hash

  • ghcr.io/jellyfishsdk/legacy-api:570fe64fbbbc7b1412dd08a88a4f9c8b267adc0d
  • ghcr.io/jellyfishsdk/playground-api:570fe64fbbbc7b1412dd08a88a4f9c8b267adc0d
  • ghcr.io/jellyfishsdk/status-api:570fe64fbbbc7b1412dd08a88a4f9c8b267adc0d
  • ghcr.io/jellyfishsdk/whale-api:570fe64fbbbc7b1412dd08a88a4f9c8b267adc0d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant