Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(packages/jellyfish-api-core): Add getBlockFilter RPC #1812

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

imkven
Copy link
Contributor

@imkven imkven commented Oct 18, 2022

What this PR does / why we need it:

Implements blockchain.getBlockFilter() from ain

Which issue(s) does this PR fixes?:

Fixes part of #48

Additional comments?:

@codeclimate
Copy link

codeclimate bot commented Oct 18, 2022

Code Climate has analyzed commit 00d31a3 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@netlify
Copy link

netlify bot commented Oct 18, 2022

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit 1c680dd
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/634e24203d60550009223750
😎 Deploy Preview https://deploy-preview-1812--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 18, 2022

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit 00d31a3
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/6391575c0700180008a74e6b
😎 Deploy Preview https://deploy-preview-1812--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 92.92% // Head: 92.81% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (00d31a3) compared to base (a36a67c).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1812      +/-   ##
==========================================
- Coverage   92.92%   92.81%   -0.12%     
==========================================
  Files         363      363              
  Lines       10562    10564       +2     
  Branches     1333     1334       +1     
==========================================
- Hits         9815     9805      -10     
- Misses        719      730      +11     
- Partials       28       29       +1     
Impacted Files Coverage Δ
...ages/jellyfish-api-core/src/category/blockchain.ts 86.66% <0.00%> (+5.27%) ⬆️
...s/legacy-api/src/controllers/PoolPairController.ts 21.59% <0.00%> (-64.78%) ⬇️
...pps/whale-api/src/module.health/probe.indicator.ts 37.50% <0.00%> (-62.50%) ⬇️
apps/whale-api/src/module.model/_model.probes.ts 26.66% <0.00%> (-60.00%) ⬇️
apps/whale-api/src/module.defid/defid.probes.ts 27.27% <0.00%> (-59.10%) ⬇️
...ps/whale-api/src/module.api/actuator.controller.ts 62.50% <0.00%> (-37.50%) ⬇️
apps/whale-api/src/module.api/subsidy.ts 66.66% <0.00%> (-25.00%) ⬇️
...ckages/jellyfish-api-core/src/category/poolpair.ts 89.28% <0.00%> (-10.72%) ⬇️
apps/libs/filters/src/ErrorFilter.ts 44.26% <0.00%> (-9.84%) ⬇️
...rc/module.api/interceptors/response.interceptor.ts 91.66% <0.00%> (-8.34%) ⬇️
... and 36 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants