Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jellyfish-api-core): add blockchain getTxOutSetInfo RPC #1775

Merged

Conversation

infinia-yzl
Copy link
Contributor

@infinia-yzl infinia-yzl commented Sep 22, 2022

What this PR does / why we need it:

/kind feature

Which issue(s) does this PR fixes?:

Fixes part of #48

  • Implements gettxoutsetinfo type for RPC.

@netlify
Copy link

netlify bot commented Sep 22, 2022

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit f4359b8
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/633159b9c97a3a000809dfb3
😎 Deploy Preview https://deploy-preview-1775--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Sep 22, 2022

Code Climate has analyzed commit f4359b8 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Base: 92.21% // Head: 92.01% // Decreases project coverage by -0.20% ⚠️

Coverage data is based on head (f4359b8) compared to base (6438695).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1775      +/-   ##
==========================================
- Coverage   92.21%   92.01%   -0.21%     
==========================================
  Files         360      360              
  Lines       10399    10401       +2     
  Branches     1302     1302              
==========================================
- Hits         9589     9570      -19     
- Misses        767      794      +27     
+ Partials       43       37       -6     
Impacted Files Coverage Δ
...ages/jellyfish-api-core/src/category/blockchain.ts 94.87% <100.00%> (+0.27%) ⬆️
packages/ocean-api-client/src/ApiResponse.ts 6.25% <0.00%> (-93.75%) ⬇️
packages/jellyfish-wallet-encrypted/src/hd_node.ts 12.12% <0.00%> (-87.88%) ⬇️
...ckages/jellyfish-network/src/TransactionSkipped.ts 37.50% <0.00%> (-50.00%) ⬇️
apps/legacy-api/src/modules/WhaleApiModule.ts 45.83% <0.00%> (-45.84%) ⬇️
packages/jellyfish-wallet-mnemonic/src/mnemonic.ts 63.63% <0.00%> (-36.37%) ⬇️
packages/whale-api-client/src/api/address.ts 66.66% <0.00%> (-33.34%) ⬇️
apps/whale-api/src/module.api/subsidy.ts 66.66% <0.00%> (-25.00%) ⬇️
...jellyfish-transaction/src/script/dftx/dftx_misc.ts 75.00% <0.00%> (-25.00%) ⬇️
...ale-api/src/module.indexer/model/dftx/pool.swap.ts 66.03% <0.00%> (-24.53%) ⬇️
... and 50 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@infinia-yzl infinia-yzl marked this pull request as ready for review September 23, 2022 11:27
fuxingloh
fuxingloh previously approved these changes Sep 23, 2022
Copy link
Contributor

@fuxingloh fuxingloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor nit, otherwise lgtm

+ change test assertions
@fuxingloh fuxingloh merged commit 1761d40 into DeFiCh:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants