Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README.md): update readme to reflect post whale-api consolidation changes #1619

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

fuxingloh
Copy link
Contributor

What this PR does / why we need it:

Remove "Watch this space!" since #580 has been closed and merged.

@jellyfishsdk-bot jellyfishsdk-bot added the kind/docs Non feature documentation change label Jul 6, 2022
@codeclimate
Copy link

codeclimate bot commented Jul 6, 2022

Code Climate has analyzed commit 00e6a9c and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Jul 6, 2022

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit 00e6a9c
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/62c52da322fce30009e211e7
😎 Deploy Preview https://deploy-preview-1619--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@fuxingloh fuxingloh marked this pull request as ready for review July 6, 2022 06:38
@github-actions
Copy link

github-actions bot commented Jul 6, 2022

Docker build preview for jellyfish/apps is ready!

Built with commit 6366c3c

  • ghcr.io/jellyfishsdk/legacy-api:pr-1619
  • ghcr.io/jellyfishsdk/ocean-api:pr-1619
  • ghcr.io/jellyfishsdk/playground-api:pr-1619
  • ghcr.io/jellyfishsdk/status-api:pr-1619
  • ghcr.io/jellyfishsdk/whale-api:pr-1619

You can also get an immutable image with the commit hash

  • ghcr.io/jellyfishsdk/legacy-api:6366c3c405980932d26c9397b223df1ca01099a3
  • ghcr.io/jellyfishsdk/ocean-api:6366c3c405980932d26c9397b223df1ca01099a3
  • ghcr.io/jellyfishsdk/playground-api:6366c3c405980932d26c9397b223df1ca01099a3
  • ghcr.io/jellyfishsdk/status-api:6366c3c405980932d26c9397b223df1ca01099a3
  • ghcr.io/jellyfishsdk/whale-api:6366c3c405980932d26c9397b223df1ca01099a3

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #1619 (00e6a9c) into main (905a3e7) will increase coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1619      +/-   ##
==========================================
+ Coverage   91.33%   91.57%   +0.23%     
==========================================
  Files         359      359              
  Lines       10351    10325      -26     
  Branches     1288     1285       -3     
==========================================
+ Hits         9454     9455       +1     
+ Misses        863      836      -27     
  Partials       34       34              
Impacted Files Coverage Δ
packages/whale-api-client/src/api/oracles.ts 22.22% <0.00%> (-77.78%) ⬇️
apps/legacy-api/src/controllers/MiscController.ts 25.80% <0.00%> (-74.20%) ⬇️
...egacy-api/src/controllers/stats/StatsController.ts 25.92% <0.00%> (-62.97%) ⬇️
...pps/whale-api/src/module.health/probe.indicator.ts 37.50% <0.00%> (-62.50%) ⬇️
apps/whale-api/src/module.defid/defid.probes.ts 27.27% <0.00%> (-59.10%) ⬇️
apps/whale-api/src/module.model/_model.probes.ts 27.58% <0.00%> (-58.63%) ⬇️
packages/jellyfish-address/src/script/P2PKH.ts 54.16% <0.00%> (-45.84%) ⬇️
...y-api/src/controllers/stats/LegacyStatsProvider.ts 47.36% <0.00%> (-45.62%) ⬇️
apps/whale-api/src/module.api/oracle.controller.ts 44.00% <0.00%> (-44.00%) ⬇️
...tus-api/src/controllers/OverallStatusController.ts 60.00% <0.00%> (-40.00%) ⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 905a3e7...00e6a9c. Read the comment docs.

@fuxingloh fuxingloh merged commit 3e094c3 into main Jul 6, 2022
@fuxingloh fuxingloh deleted the fuxingloh/readme branch July 6, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/docs Non feature documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants