Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jellyfish-transaction, jellyfish-transaction-builder): Add withdrawfutureswap dftx #1337

Closed
wants to merge 27 commits into from

Conversation

jingyi2811
Copy link
Contributor

@jingyi2811 jingyi2811 commented Apr 11, 2022

What this PR does / why we need it:

Add withdrawfutureswap dftx

Which issue(s) does this PR fixes?:

Fixes part of #1268

Additional comments?:

@codeclimate
Copy link

codeclimate bot commented Apr 11, 2022

Code Climate has analyzed commit 26ddaa1 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Apr 11, 2022

Deploy Preview for jellyfish-defi ready!

Name Link
🔨 Latest commit 26ddaa1
🔍 Latest deploy log https://app.netlify.com/sites/jellyfish-defi/deploys/6253c7182aeada00095f886d
😎 Deploy Preview https://deploy-preview-1337--jellyfish-defi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #1337 (90a34f2) into main (34e1724) will increase coverage by 1.62%.
The diff coverage is 100.00%.

❗ Current head 90a34f2 differs from pull request most recent head 26ddaa1. Consider uploading reports for the commit 26ddaa1 to get more accurate results

@@            Coverage Diff             @@
##             main    #1337      +/-   ##
==========================================
+ Coverage   88.13%   89.75%   +1.62%     
==========================================
  Files         339      348       +9     
  Lines        9858    10027     +169     
  Branches     1211     1223      +12     
==========================================
+ Hits         8688     9000     +312     
+ Misses       1109      978     -131     
+ Partials       61       49      -12     
Impacted Files Coverage Δ
...transaction-builder/src/txn/txn_builder_account.ts 100.00% <100.00%> (+34.28%) ⬆️
...ages/jellyfish-transaction/src/script/dftx/dftx.ts 97.05% <100.00%> (-1.45%) ⬇️
...lyfish-transaction/src/script/dftx/dftx_account.ts 100.00% <100.00%> (ø)
...ckages/jellyfish-transaction/src/script/mapping.ts 95.39% <100.00%> (+2.06%) ⬆️
...ners/src/containers/RegTestContainer/Persistent.ts 11.11% <0.00%> (-81.49%) ⬇️
packages/jellyfish-testing/src/rawtx.ts 15.00% <0.00%> (-77.50%) ⬇️
packages/jellyfish-testing/src/poolpair.ts 80.95% <0.00%> (-19.05%) ⬇️
...ransaction-builder/src/txn/txn_builder_liq_pool.ts 85.71% <0.00%> (-14.29%) ⬇️
...ellyfish-transaction/src/script/dftx/dftx_token.ts 88.37% <0.00%> (-11.63%) ⬇️
...ages/jellyfish-api-core/src/category/governance.ts 90.90% <0.00%> (-9.10%) ⬇️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34e1724...26ddaa1. Read the comment docs.

@github-actions
Copy link

Docker build preview for jellyfish/apps is ready!

Built with commit 9e092a7

  • ghcr.io/defich/legacy-api:pr-1337
  • ghcr.io/defich/ocean-api:pr-1337
  • ghcr.io/defich/playground-api:pr-1337
  • ghcr.io/defich/status-api:pr-1337

@jingyi2811 jingyi2811 closed this Apr 18, 2022
@jingyi2811 jingyi2811 deleted the jimmy/dftx-withdrawfutureswap branch April 18, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants