-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jellyfish-transaction, jellyfish-transaction-builder): Add futureswap dftxs #1329
Conversation
This reverts commit 4d137e2.
Code Climate has analyzed commit 04001e7 and detected 0 issues on this pull request. View more on Code Climate. |
✅ Deploy Preview for jellyfish-defi ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #1329 +/- ##
==========================================
+ Coverage 83.39% 88.01% +4.61%
==========================================
Files 335 347 +12
Lines 9737 10027 +290
Branches 1195 1224 +29
==========================================
+ Hits 8120 8825 +705
+ Misses 1517 1127 -390
+ Partials 100 75 -25
Continue to review full report at Codecov.
|
Docker build preview for jellyfish/apps is ready! Built with commit a8d1aa9
|
2142f4b
to
e8f9741
Compare
This PR is good to be merged to main. Before merging, it is good to add this test item Maybe @surangap you have good reason to remove this in your dftx test file, kindly advise |
yeah two reasons
We need to update the above👆 functions to have it done within one block and check. |
@jingyi2811 |
What this PR does / why we need it:
Add
futureswap
andwithdrawfutureswap
dftxsWhich issue(s) does this PR fixes?:
Fixes part of #1268
Additional comments?: