-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jellyfish-api-core): Add listPendingFutureSwaps RPC for dfip2203 futures #1319
Conversation
…reswaps # Conflicts: # packages/testcontainers/src/containers/DeFiDContainer.ts
✅ Deploy Preview for jellyfish-defi ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Code Climate has analyzed commit 3ab839a and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #1319 +/- ##
==========================================
+ Coverage 90.20% 90.62% +0.41%
==========================================
Files 348 348
Lines 10010 10012 +2
Branches 1222 1222
==========================================
+ Hits 9030 9073 +43
+ Misses 934 895 -39
+ Partials 46 44 -2
Continue to review full report at Codecov.
|
Docker build preview for jellyfish/apps is ready! Built with commit 5b5fc2f
|
packages/jellyfish-api-core/__tests__/category/account/listPendingFutureSwaps.test.ts
Outdated
Show resolved
Hide resolved
packages/jellyfish-api-core/__tests__/category/account/listPendingFutureSwaps.test.ts
Outdated
Show resolved
Hide resolved
It is better to review #1321 before this PR. The final design of 1321 will somehow determine how the test looks like in this PR. C++ side hasn't added pagination to this RPC. Once they do so, I still need to improve the test written in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. add a test like #1321 (review)
…reswaps # Conflicts: # docs/node/CATEGORIES/08-account.md # docs/node/CATEGORIES/09-oracle.md # packages/jellyfish-api-core/src/category/account.ts # packages/testcontainers/src/containers/DeFiDContainer.ts
…reswaps # Conflicts: # docs/node/CATEGORIES/08-account.md # packages/jellyfish-api-core/src/category/account.ts
What this PR does / why we need it:
Add listPendingFutureSwaps RPC
Which issue(s) does this PR fixes?:
Fixes part of #1268
Additional comments?: