Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jellyfish-api-core): Add listPendingFutureSwaps RPC for dfip2203 futures #1319

Merged
merged 18 commits into from
Apr 11, 2022

Conversation

jingyi2811
Copy link
Contributor

@jingyi2811 jingyi2811 commented Apr 5, 2022

What this PR does / why we need it:

Add listPendingFutureSwaps RPC

Which issue(s) does this PR fixes?:

Fixes part of #1268

Additional comments?:

…reswaps

# Conflicts:
#	packages/testcontainers/src/containers/DeFiDContainer.ts
@netlify
Copy link

netlify bot commented Apr 5, 2022

Deploy Preview for jellyfish-defi ready!

Name Link
🔨 Latest commit 3ab839a
🔍 Latest deploy log https://app.netlify.com/sites/jellyfish-defi/deploys/6251a46ce97c6600085f06c2
😎 Deploy Preview https://deploy-preview-1319--jellyfish-defi.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Apr 5, 2022

Code Climate has analyzed commit 3ab839a and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #1319 (3ab839a) into main (76e443a) will increase coverage by 0.41%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1319      +/-   ##
==========================================
+ Coverage   90.20%   90.62%   +0.41%     
==========================================
  Files         348      348              
  Lines       10010    10012       +2     
  Branches     1222     1222              
==========================================
+ Hits         9030     9073      +43     
+ Misses        934      895      -39     
+ Partials       46       44       -2     
Impacted Files Coverage Δ
...ackages/jellyfish-api-core/src/category/account.ts 100.00% <100.00%> (ø)
...an-api-client/src/errors/ApiValidationException.ts 50.00% <0.00%> (-50.00%) ⬇️
...ckages/ocean-api-client/src/errors/ApiException.ts 72.22% <0.00%> (-27.78%) ⬇️
...h-transaction-builder/src/txn/txn_builder_loans.ts 77.14% <0.00%> (-22.86%) ⬇️
...nsaction-builder/src/txn/txn_builder_governance.ts 90.47% <0.00%> (-9.53%) ⬇️
...llyfish-transaction-builder/src/txn/txn_builder.ts 89.28% <0.00%> (-8.93%) ⬇️
packages/jellyfish-json/src/index.ts 86.20% <0.00%> (-6.90%) ⬇️
...ages/jellyfish-api-core/src/category/blockchain.ts 94.28% <0.00%> (-5.72%) ⬇️
packages/jellyfish-api-core/src/category/loan.ts 96.96% <0.00%> (-3.04%) ⬇️
...kages/jellyfish-wallet-encrypted/src/encryption.ts 92.30% <0.00%> (-1.54%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76e443a...3ab839a. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 5, 2022

Docker build preview for jellyfish/apps is ready!

Built with commit 5b5fc2f

  • ghcr.io/defich/legacy-api:pr-1319
  • ghcr.io/defich/ocean-api:pr-1319
  • ghcr.io/defich/playground-api:pr-1319
  • ghcr.io/defich/status-api:pr-1319

@jingyi2811 jingyi2811 changed the title Add listPendingFutureSwaps RPC feat(jellyfish-api-core): Add oracle listPendingFutureSwaps RPC for dfip2203 futures Apr 7, 2022
@defichain-bot defichain-bot added the kind/feature New feature request label Apr 7, 2022
@jingyi2811
Copy link
Contributor Author

jingyi2811 commented Apr 7, 2022

It is better to review #1321 before this PR. The final design of 1321 will somehow determine how the test looks like in this PR.

C++ side hasn't added pagination to this RPC. Once they do so, I still need to improve the test written in this PR.

@jingyi2811 jingyi2811 marked this pull request as ready for review April 7, 2022 04:41
@surangap surangap changed the title feat(jellyfish-api-core): Add oracle listPendingFutureSwaps RPC for dfip2203 futures feat(jellyfish-api-core): Add listPendingFutureSwaps RPC for dfip2203 futures Apr 7, 2022
Copy link
Contributor

@surangap surangap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. add a test like #1321 (review)

…reswaps

# Conflicts:
#	docs/node/CATEGORIES/08-account.md
#	docs/node/CATEGORIES/09-oracle.md
#	packages/jellyfish-api-core/src/category/account.ts
#	packages/testcontainers/src/containers/DeFiDContainer.ts
…reswaps

# Conflicts:
#	docs/node/CATEGORIES/08-account.md
#	packages/jellyfish-api-core/src/category/account.ts
@fuxingloh fuxingloh merged commit 34e1724 into main Apr 11, 2022
@fuxingloh fuxingloh deleted the jimmy/listpendingfutureswaps branch April 11, 2022 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants