Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added bech32 & wif into jellyfish-crypto #129

Merged
merged 5 commits into from
Apr 17, 2021
Merged

Conversation

fuxingloh
Copy link
Contributor

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Added WIF to jellyfish-crypto since it can be used to get a private key using secp256k1.
Added bech32 address from and to utils to jellyfish-crypto as it uses HASH160 function to encode addresses.

@github-actions
Copy link

github-actions bot commented Apr 16, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 17.13 KB (0%) 343 ms (0%) 163 ms (+0.98% 🔺) 505 ms

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #129 (86bafaa) into main (dd1851e) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   94.38%   94.48%   +0.09%     
==========================================
  Files          37       39       +2     
  Lines         784      816      +32     
  Branches       93       95       +2     
==========================================
+ Hits          740      771      +31     
- Misses         42       43       +1     
  Partials        2        2              
Impacted Files Coverage Δ
packages/jellyfish-crypto/src/bech32.ts 100.00% <100.00%> (ø)
packages/jellyfish-crypto/src/elliptic.ts 95.23% <100.00%> (+1.90%) ⬆️
packages/jellyfish-crypto/src/index.ts 100.00% <100.00%> (ø)
packages/jellyfish-crypto/src/wif.ts 100.00% <100.00%> (ø)
packages/jellyfish-crypto/src/der.ts 90.90% <0.00%> (-4.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd1851e...86bafaa. Read the comment docs.

@fuxingloh fuxingloh force-pushed the fuxingloh/jellyfish-crypto branch from 63095e2 to 86bafaa Compare April 17, 2021 07:45
@fuxingloh fuxingloh marked this pull request as ready for review April 17, 2021 08:01
@fuxingloh fuxingloh enabled auto-merge (squash) April 17, 2021 08:02
@fuxingloh fuxingloh disabled auto-merge April 17, 2021 08:29
@fuxingloh fuxingloh merged commit 8d70572 into main Apr 17, 2021
@fuxingloh fuxingloh deleted the fuxingloh/jellyfish-crypto branch April 17, 2021 08:29
eli-lim pushed a commit that referenced this pull request Mar 27, 2022
canonbrother pushed a commit that referenced this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants