Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address validation for p2sh, p2pkh, p2wpkh, p2wsh #139

Closed
fuxingloh opened this issue Apr 18, 2021 · 1 comment · Fixed by #189
Closed

address validation for p2sh, p2pkh, p2wpkh, p2wsh #139

fuxingloh opened this issue Apr 18, 2021 · 1 comment · Fixed by #189
Assignees
@ivan-zynesis
Labels
kind/feature New feature request priority/important-soon Will be important soon triage/accepted Triage has been accepted
Milestone
Jellyfish Wallet

Comments

@fuxingloh
Copy link
Contributor

What would you like to be added:

jellyfish-network or jellyfish-wallet should implement a validator and guess what kind of address this is.

Why is this needed:

For client/wallet app this provides an utility to present the type of address user are sending their crypto assets to.
@fuxingloh fuxingloh added kind/feature New feature request triage/accepted Triage has been accepted area/jellyfish-wallet labels Apr 18, 2021
@fuxingloh fuxingloh added this to the Jellyfish Wallet milestone Apr 18, 2021
@fuxingloh fuxingloh self-assigned this Apr 18, 2021
@fuxingloh fuxingloh mentioned this issue Apr 18, 2021
Merged
@fuxingloh fuxingloh added the priority/important-soon Will be important soon label Apr 20, 2021
@fuxingloh fuxingloh assigned ivan-zynesis and unassigned fuxingloh May 3, 2021
@fuxingloh
Copy link
Contributor Author

Within the realm of jellyfish-transactions.

We need a class/interface in jellyfish-transactions for UX/UI to detect where the transfer is going to.
The intention is when user does a light wallet transfer; and when they key in an address, they can see what type of address it is. Also to do validation on whether that the address is valid.

@fuxingloh fuxingloh mentioned this issue May 6, 2021
Closed
@ivan-zynesis ivan-zynesis linked a pull request May 11, 2021 that will close this issue
guess P2SH / P2PKH / P2WSH / P2WPKH type #189
Merged
eli-lim pushed a commit that referenced this issue Mar 27, 2022
@fuxingloh
fix typo in LEVEL_UP_LOCATION (#139)
5b07dd6
canonbrother pushed a commit that referenced this issue Jun 1, 2022
@fuxingloh
fix typo in LEVEL_UP_LOCATION (#139)
5dc6521
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivan-zynesis ivan-zynesis

Labels
kind/feature New feature request priority/important-soon Will be important soon triage/accepted Triage has been accepted
Projects
None yet
Milestone
Jellyfish Wallet
Development

Successfully merging a pull request may close this issue.

guess P2SH / P2PKH / P2WSH / P2WPKH type DeFiCh/jellyfishsdk
2 participants
@fuxingloh @ivan-zynesis