Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept devnet/localhost node URLs #10

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

dcorral
Copy link

@dcorral dcorral commented Apr 25, 2023

What this PR does / why we need it:

  • IMPORTANT: NODE_URL secret is mandatory and must include a trailing '/' i.e http://localhost:port/
  • Tests can point to http://localhost:port URL skipping Basic Auth header if not required.
  • Ability to set the target URL to a public or local endpoint not implementing Basic Auth. This is the case of devnet public endpoint ATM.

To fix:

  • TestConnection_Call_Simple_Contract
  • TestConnection_Get_Accounts
  • TestConnection_Get_Balance
  • TestConnection_GetTransactionCount
  • TestConnection_EstimateGas
  • TestConnection_MaxPriorityFeePerGas
  • TestConnection_GasPrice
  • TestConnection_NetVersion
  • TestConnection_ChainId
  • TestConnection_SendRawTransactionInValidEmpty
  • TestConnection_SendRawTransactionInValidOldNonce
  • TestConnection_FutureBlockByNumber
  • TestConnection_InvalidBlockByHash
  • TestConnection_InvalidTransactionByHash

@dcorral dcorral merged commit 6ea5a4a into master Apr 26, 2023
@dcorral dcorral deleted the dcorral/accept_devnet_local_node_url branch April 26, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant