Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collateral increases in value and should be able to be withdrawn #988

Merged
merged 24 commits into from
Jan 21, 2022

Conversation

Jouzo
Copy link
Collaborator

@Jouzo Jouzo commented Dec 14, 2021

What kind of PR is this?:

/kind fix

What this PR does / why we need it:

When a collateral increases a value, it should be allowed to be withdrawn even if ratio with DFI ratio is still below 50%.

@bvbfan bvbfan self-requested a review December 29, 2021 12:46
bvbfan
bvbfan previously approved these changes Dec 29, 2021
@bvbfan bvbfan self-requested a review January 11, 2022 11:28
bvbfan
bvbfan previously approved these changes Jan 11, 2022
prasannavl
prasannavl previously approved these changes Jan 11, 2022
@Jouzo Jouzo dismissed stale reviews from prasannavl and bvbfan via c565aaa January 12, 2022 09:56
Copy link
Contributor

@uzyn uzyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo.

For future: Probably good for us to have a centralized error management instead of repeating these.

src/masternodes/mn_checks.cpp Outdated Show resolved Hide resolved
src/masternodes/mn_checks.cpp Outdated Show resolved Hide resolved
src/masternodes/mn_checks.cpp Outdated Show resolved Hide resolved
@bvbfan bvbfan self-requested a review January 19, 2022 11:45
bvbfan
bvbfan previously approved these changes Jan 19, 2022
@prasannavl prasannavl merged commit b63a433 into master Jan 21, 2022
@prasannavl prasannavl deleted the fix/withdraw_collateral branch January 21, 2022 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants