-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new CRPCStats class to save key RPC statistics #970
Conversation
a562c37
to
e8d483e
Compare
Use something on the lines of
for the internal memory repr and serialize / deserliaze in one-go. Currently, each UniValue is (which adds up quickly)
|
5195180
to
52f04df
Compare
f8cf4e3
to
3257ece
Compare
The reason this PR is still pending is that, |
77cd761
to
7000675
Compare
@Jouzo rebase to |
9d42c10
to
344566f
Compare
Based on #970 (comment), the shared resource usage is well covered as it is right now. All usages are simple value types that are copied over on the stack as stated in the above. Let's make sure there are no usage patterns that cause dead lock and we can proceed to merge. |
6fc8268
to
344566f
Compare
Build failure was due to v3 branch. Should be good now. |
* Add CRPCStats to log RPC usage * Use CLockFreeMutex * Copy map via getMap method
* Introduce new CRPCStats class to save key RPC statistics (#970) * Add CRPCStats to log RPC usage * Use CLockFreeMutex * Copy map via getMap method * Use atomic_bool for CLockFreeGuard
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
Save RPC latency and payload size on each call.
Introduces 2 RPCs:
getrpcstats
: